return empty when table or databse is not set

[OhJuhun]

resolve: #931
This situation should not return an error; if nothing is selected, it would be appropriate to return an empty value and handle it as normal. Please let me know if you have any other opinions.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9d4454a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[vercel]

@OhJuhun is attempting to deploy a commit to the HyperDX Team on Vercel.

A member of the Team first needs to authorize it.

[knudtty]

Thanks for bringing this up and raising a PR! Unfortunately I still see the error that I think you're describing. I have a few changes I'd want to see

1. Base off of the main branch (you can just hit the 'Update Branch' button on this PR). We recently merged v2 into main, and main is the primary target for PRs now
2. I think the issue originates from metadata queries, specifically the getColumns method. In packages/common-utils/src/metadata.ts, add this database & table truthiness check like you have, but just return an empty array in those cases. You can add it to other similar metadata methods too (getAllFields, getKeyValues, etc.) and I believe that should future-proof us from introducing similar issues

Thanks for identifying this issue that rightly needs fixing!