Skip to content

feat: Add click + sidepanel support to items within surrounding context #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Jul 30, 2025

Conversation

teeohhem
Copy link
Contributor

@teeohhem teeohhem commented Jul 10, 2025

Fixes HDX-1951

Copy link

changeset-bot bot commented Jul 10, 2025

🦋 Changeset detected

Latest commit: 7b20e0e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hyperdx-v2-oss-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 30, 2025 5:28pm

},
[source.id, setContextRowId, setContextRowSource],
);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: URL state is used for the side panel. This allows us to expand into local state for nested panels as to not add additional complexity into url state

Copy link
Contributor

github-actions bot commented Jul 10, 2025

Stably Runner - Test Suite - 'Smoke Test'

Test Suite Run Result: 🟢 Success (4/4 tests passed) [dashboard]


This comment was generated from stably-runner-action

Copy link
Contributor

@knudtty knudtty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works like a charm! great feature

@kodiakhq kodiakhq bot merged commit 86115fa into main Jul 30, 2025
7 of 8 checks passed
@kodiakhq kodiakhq bot deleted the tom/surrounding-context-click-2 branch July 30, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants