feat: Add click + sidepanel support to items within surrounding context #989
Conversation
🦋 Changeset detectedLatest commit: 1a70cf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| ]} | ||
| value={range.toString()} | ||
| onChange={value => setRange(Number(value))} | ||
| const contextComponent = config && ( |
There was a problem hiding this comment.
just moving this into its own component for readability
There was a problem hiding this comment.
Should this be a proper component instead?
const ContextComponent = () => config ? (
...
) : (<></>);
| }, | ||
| [source.id, setContextRowId, setContextRowSource], | ||
| ); | ||
|
|
There was a problem hiding this comment.
TL;DR: URL state is used for the side panel. This allows us to expand into local state for nested panels as to not add additional complexity into url state
Stably Runner - Test Suite - 'Smoke Test'Test Suite Run Result: 🟢 Success (4/4 tests passed) [dashboard] This comment was generated from stably-runner-action |
| @@ -230,6 +235,8 @@ const DBRowSidePanel = ({ | |||
| mainContent={mainContent} | |||
| mainContentHeader={mainContentColumn} | |||
| severityText={severityText} | |||
| breadcrumbPath={breadcrumbPath} | |||
| onBreadcrumbClick={onClose} | |||
There was a problem hiding this comment.
It seems when I click a breadcrumb, it just pops the top off the stack rather than popping all until the crumb I click on. Is that intended?
There was a problem hiding this comment.
Hmm that seems like a bug. Let me fix!
Fixes HDX-1951