Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to 2018 edition #173

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

tottoto
Copy link
Contributor

@tottoto tottoto commented Mar 6, 2024

Updates to 2018 edition.

@tottoto tottoto force-pushed the update-to-edition-2021 branch 2 times, most recently from b0dbba4 to e84d08b Compare March 6, 2024 15:16
@tottoto tottoto marked this pull request as draft March 6, 2024 15:23
@tottoto
Copy link
Contributor Author

tottoto commented Mar 6, 2024

The crates' edition in the workspace seems to affect the testing the other crates which do not support the version especially when testing msrv.

@tottoto tottoto closed this Mar 6, 2024
@tottoto tottoto reopened this Mar 6, 2024
@tottoto tottoto force-pushed the update-to-edition-2021 branch from e84d08b to 581a199 Compare March 6, 2024 15:56
@tottoto tottoto changed the title chore: update to 2021 edition chore: update to 2018 edition Mar 6, 2024
@tottoto
Copy link
Contributor Author

tottoto commented Mar 6, 2024

Changed to update to 2018 edition, which headers-core's msrv supports.

@tottoto tottoto marked this pull request as ready for review March 6, 2024 16:00
Copy link
Member

@seanmonstar seanmonstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😯

@seanmonstar seanmonstar merged commit 2c9b996 into hyperium:master Mar 6, 2024
6 checks passed
@tottoto tottoto deleted the update-to-edition-2021 branch March 6, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants