fix: missing send error field when an error response exists (#1217)

* fix: missing send error field when an error response is exist * fix: send error to /event * fix test --------- Co-authored-by: Kevin Hermawan <[email protected]> Co-authored-by: Mochamad Noor Syamsu <[email protected]>
hyperjumptech · Dec 22, 2023 · 8688b32 · 8688b32
1 parent ed79689
commit 8688b32
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/src/components/probe/prober/http/request.ts b/src/components/probe/prober/http/request.ts
@@ -193,12 +193,13 @@ export async function httpRequest({
       // 400, 500 get here
       if (error?.response) {
         return {
-          data: error?.response?.data,
-          body: error?.response?.data,
-          status: error?.response?.status as number,
+          data: '',
+          body: '',
+          status: error?.response?.status,
           headers: error?.response?.headers,
           responseTime,
           result: probeRequestResult.success,
+          error: error?.response?.data,
         }
       }
 
@@ -208,13 +209,13 @@ export async function httpRequest({
         const { status, description } = getErrorStatusWithExplanation(error)
 
         return {
-          data: description,
+          data: '',
           body: '',
           status,
           headers: '',
           responseTime,
           result: probeRequestResult.failed,
-          error: (error as AxiosError).message,
+          error: description,
         }
       }
     }

diff --git a/src/symon/index.ts b/src/symon/index.ts
@@ -291,7 +291,8 @@ export default class SymonClient {
     validation,
     alertId,
   }: NotificationEvent) {
-    const { data, headers, responseTime, status } = validation.response
+    const { data, headers, responseTime, status, error } = validation.response
+
     this.httpClient
       .post('/events', {
         monikaId: this.monikaId,
@@ -303,6 +304,7 @@ export default class SymonClient {
           size: headers['content-length'],
           status, // status is http status code
           time: responseTime,
+          error,
         },
       })
       .then(() => {