Skip to content

Commit

Permalink
Update to Node to v20.x (#1235)
Browse files Browse the repository at this point in the history
* update to node 20x
* update base docker image
* update package and lock
  • Loading branch information
sapiderman authored Feb 12, 2024
1 parent 040c741 commit d96b3e1
Show file tree
Hide file tree
Showing 14 changed files with 33 additions and 33 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/auto-pr-schemastore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: ✍🏻 Setup node
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x

- name: Run Test on Schema
run: |
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docker-release-from-tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- name: 🔧 Setup Node
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x

- name: 📥 Install Dependencies
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/docs-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
- name: ✍🏻 Setup node
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x

- name: 📥 Install deps
run: npm install --legacy-peer-deps
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
- name: ✍🏻 Setup node
uses: actions/setup-node@v4
with:
node-version: 16.14
node-version: 20.x

- name: 📥 Install deps
run: npm ci
Expand Down Expand Up @@ -69,7 +69,7 @@ jobs:
- name: ✍🏻 Setup node
uses: actions/setup-node@v4
with:
node-version: 16.14
node-version: 20.x

- name: 📥 Install deps
run: npm ci
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: 🔧 Setup Node
uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x

- name: 📥 Install Dependencies
run: npm ci
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
- run: npm ci
- run: npm run build -w packages/notification
- run: npm run lint
Expand All @@ -36,10 +36,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
- run: npm ci
- run: npm run build -w packages/notification
- run: npm run format
Expand All @@ -50,10 +50,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
- run: npm ci
- run: npm run build -w packages/notification
- run: npm pack
Expand All @@ -66,10 +66,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
- run: npm ci
- run: npm run build -w packages/notification
- run: npm pack
Expand All @@ -84,10 +84,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 18.x
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 18.x
node-version: 20.x
- run: npm ci
- run: npm run build -w packages/notification
- run: npm test && npx codecov
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/npm-notification-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x
- run: npm ci
- run: npm run build -w packages/notification
- run: npm pack
Expand All @@ -35,7 +35,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x
registry-url: https://registry.npmjs.org/
- run: npm ci
- run: npm run build -w packages/notification
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/npm-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x
- run: npm ci
- run: npm run build -w packages/notification
- run: npm test
Expand All @@ -31,7 +31,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x
- run: npm ci
- run: npm run build -w packages/notification
- run: npm pack
Expand All @@ -45,7 +45,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x
registry-url: https://registry.npmjs.org/
- run: npm ci
- run: npm run build -w packages/notification
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/publish-snap.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x
- run: npm ci
name: Install dependencies
- run: npm run build -w packages/notification
Expand All @@ -38,7 +38,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x
- run: npm ci --workspaces --if-present
name: Install workspaces dependencies
- run: npm run build --workspaces --if-present
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/upload-binary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x
- run: npm ci
name: Install dependencies
- run: npm run build -w packages/notification
Expand Down Expand Up @@ -58,7 +58,7 @@ jobs:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: 20.x

- run: echo ::set-output name=VERSION::${GITHUB_REF/refs\/tags\//}
name: Get version
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18-alpine AS builder
FROM node:20-alpine AS builder

WORKDIR /monika

Expand Down
2 changes: 1 addition & 1 deletion Dockerfile.flyio
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM node:18-alpine
FROM node:20-alpine

RUN apk add --no-cache --virtual .gyp python3 make g++

Expand Down
2 changes: 1 addition & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
"singleQuote": true
},
"engines": {
"node": ">=18.0.0"
"node": ">=20.0.0"
},
"files": [
"/bin",
Expand Down Expand Up @@ -196,9 +196,9 @@
"node_modules/sqlite3/lib/binding/**/*"
],
"targets": [
"node18-linux-x64",
"node18-macos-x64",
"node18-win-x64"
"node20-linux-x64",
"node20-macos-x64",
"node20-win-x64"
],
"patches": {
"./node_modules/thread-stream/lib/worker.js": [
Expand All @@ -213,7 +213,7 @@
"outputPath": "dist"
},
"volta": {
"node": "18.14.0"
"node": "20.11.0"
},
"workspaces": [
"packages/*"
Expand Down

0 comments on commit d96b3e1

Please sign in to comment.