Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Cleanup eslint warns #1221

Merged

Conversation

syamsudotdev
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Clean up fixable ESLint warnings

How did you implement / how did you fix it

  1. Clean up ESLint warnings based on ESLint recommendations

How to test

  1. npm test
  2. npm pack && npm i -g hyperjumptech-monika-*.tgz
  3. monika

Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (ed79689) 63.80% compared to head (d8e2c7d) 63.80%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/components/probe/prober/postgres/index.ts 20.00% 0 Missing and 4 partials ⚠️
src/components/probe/prober/http/index.ts 0.00% 1 Missing ⚠️
src/components/probe/prober/mariadb/index.ts 0.00% 0 Missing and 1 partial ⚠️
src/components/probe/prober/postgres/request.ts 66.66% 0 Missing and 1 partial ⚠️
src/plugins/metrics/prometheus/collector.ts 66.66% 0 Missing and 1 partial ⚠️
...ins/validate-response/checkers/query-expression.ts 0.00% 0 Missing and 1 partial ⚠️
src/symon/index.ts 50.00% 0 Missing and 1 partial ⚠️
src/utils/expression-parser.ts 50.00% 1 Missing ⚠️
src/utils/ping.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1221   +/-   ##
=======================================
  Coverage   63.80%   63.80%           
=======================================
  Files         111      111           
  Lines        3277     3277           
  Branches      556      561    +5     
=======================================
  Hits         2091     2091           
+ Misses       1000      999    -1     
- Partials      186      187    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syamsudotdev syamsudotdev marked this pull request as ready for review December 24, 2023 10:17
@syamsudotdev syamsudotdev changed the title Chore/cleanup eslint warns Chore: Cleanup eslint warns Dec 24, 2023
Copy link
Contributor

@sapiderman sapiderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@sapiderman sapiderman merged commit 565a200 into hyperjumptech:main Dec 28, 2023
8 checks passed
@syamsudotdev syamsudotdev deleted the chore/cleanup-eslint-warns branch December 28, 2023 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants