Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Bump Oclif versions #1224

Merged
merged 3 commits into from
Jan 8, 2024

Conversation

syamsudotdev
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Update Oclif versions

How did you implement / how did you fix it

  1. Update @oclif/core to v3
  2. Update @oclif/plugin-help to v6
  3. Update @oclif/plugin-version to v2

How to test

  1. npm run prepack
  2. npm run pack
  3. npm i -g hyperjumptech-monika-1.16.3.tgz
  4. monika

Test result on MacOS

image

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (419b9f0) 63.80% compared to head (7d1e060) 63.86%.

❗ Current head 7d1e060 differs from pull request most recent head faf7810. Consider uploading reports for the commit faf7810 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1224      +/-   ##
==========================================
+ Coverage   63.80%   63.86%   +0.06%     
==========================================
  Files         111      111              
  Lines        3277     3277              
  Branches      561      561              
==========================================
+ Hits         2091     2093       +2     
+ Misses        999      998       -1     
+ Partials      187      186       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syamsudotdev syamsudotdev marked this pull request as ready for review January 5, 2024 07:44
@syamsudotdev syamsudotdev marked this pull request as draft January 5, 2024 07:45
 Conflicts:
	package-lock.json
@syamsudotdev syamsudotdev self-assigned this Jan 8, 2024
Copy link
Contributor

@dennypradipta dennypradipta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NPM test seems to be working. Let's see how this goes.

Edit: Symon mode is working too:
image

@syamsudotdev syamsudotdev merged commit e6a6be2 into hyperjumptech:main Jan 8, 2024
5 checks passed
@syamsudotdev syamsudotdev deleted the chore/bump-oclif branch January 8, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants