Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Separate Create Config Handler #1272

Conversation

haricnugraha
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

To make the transition to multi-command (#1154) easier, this changes extract the create config handler into one file.

How did you implement / how did you fix it

Extract create config handler into a file.

How to test

  • Run npm run start -- --create-config
  • Run npm test

@haricnugraha haricnugraha marked this pull request as ready for review April 17, 2024 10:48
Copy link
Contributor

@raosan raosan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haricnugraha haricnugraha merged commit ac30cf2 into hyperjumptech:main Apr 18, 2024
5 checks passed
@haricnugraha haricnugraha deleted the refactor/separate-create-config-handler branch April 18, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants