Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: adding sendWithCustomContent in monika-notif #1283

Merged
merged 3 commits into from
May 2, 2024

Conversation

raosan
Copy link
Contributor

@raosan raosan commented May 2, 2024

Monika Pull Request (PR)

What feature/issue does this PR add

  1. Implement sendWithCustomContent in monika-notif like Feat: adding sendWithCustomContent in sendgrid #1109

How did you implement / how did you fix it

  1. export types to be used in neosense
  2. add sendWithCustomContent function to support Neosense

How to test

  1. run monika with monika-notif notification config
  2. check is monika running without error
  3. get WhatsApp notif that monika is starting and nothing is broken
    Screenshot 2024-05-02 at 10 36 39 2

Copy link

codecov bot commented May 2, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 64.02%. Comparing base (6a29470) to head (e5000de).
Report is 8 commits behind head on main.

Files Patch % Lines
packages/notification/channel/monika-notif.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1283      +/-   ##
==========================================
+ Coverage   62.51%   64.02%   +1.50%     
==========================================
  Files         112      108       -4     
  Lines        3391     3372      -19     
  Branches      591      572      -19     
==========================================
+ Hits         2120     2159      +39     
+ Misses       1079     1032      -47     
+ Partials      192      181      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raosan raosan merged commit e3624cd into hyperjumptech:main May 2, 2024
8 checks passed
@raosan raosan deleted the issue/8204 branch May 3, 2024 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants