Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Disable Cache by Default #1297

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Feat: Disable Cache by Default #1297

merged 1 commit into from
Jun 21, 2024

Conversation

haricnugraha
Copy link
Contributor

Monika Pull Request (PR)

What feature/issue does this PR add

Disable cache by default.

How did you implement / how did you fix it

Change the default value of the ttl-cache flag.

How to test

  1. Run docker compose -f ./dev/docker-compose.yaml up httpbin.
  2. Run npm start with the following configuration.
probes:
  - id: '1'
    requests:
      - url: http://localhost:3002/status/200
    interval: 3
    incidentThreshold: 1
    recoveryThreshold: 1
  1. Stop the docker compose command from the step one.
  2. Re-run the docker compose command from the step one.

Demo

Before

before.mov

After

after.mov

budhihyperjump

This comment was marked as duplicate.

Sign in to view

syamsudotdev
syamsudotdev approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@syamsudotdev syamsudotdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sapiderman sapiderman merged commit 43dfe9b into hyperjumptech:main Jun 21, 2024
8 checks passed
@haricnugraha haricnugraha deleted the feat/disable-cache-by-default branch June 21, 2024 10:03
sapiderman pushed a commit to sapiderman/monika that referenced this pull request Jun 25, 2024
@haricnugraha @sapiderman
feat: disable cache by default (hyperjumptech#1297)
c1d30f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sapiderman sapiderman sapiderman approved these changes

@syamsudotdev syamsudotdev syamsudotdev approved these changes

@budhihyperjump budhihyperjump budhihyperjump approved these changes

@raosan raosan Awaiting requested review from raosan

@ilmiawan ilmiawan Awaiting requested review from ilmiawan

@lukman7788 lukman7788 Awaiting requested review from lukman7788

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haricnugraha @sapiderman @syamsudotdev @budhihyperjump