feat: zksync support #4725
Open
feat: zksync support #4725
+2,381
−389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in favor of MultiChainResolver
feat: zksync post verifier
refactor: consolidate ISM compatibility logic and static deployment c…
…r' into feat/zksync-support
ltyu
dismissed
jmrossy’s stale review
It seems like most issues were resolved and/or outdated
jmrossy
reviewed
Jan 17, 2025
xeno097
reviewed
Jan 17, 2025
Comment on lines
+15
to
+20
| networks: { | ||
| zkSyncNetwork: { | ||
| url: 'http://127.0.0.1:8011', | ||
| ethNetwork: '', | ||
| zksync: true, | ||
| }, |
There was a problem hiding this comment.
Is this needed for building the zk-sync artifacts or can it be removed?
There was a problem hiding this comment.
Would keep it there, removing the zksync network reference has been know to cause issues for some reason
xeno097
approved these changes
Jan 17, 2025
This was referenced Jan 20, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 22, 2025
### Description ZKSync PR 1 This PR introduces ZKSync support for Solidity contracts and restructures build files directory structure. ### Drive-by changes - Added ZKSync compilation support using zksolc via `@matterlabs/hardhat-zksync-solc` - Restructured typechain directory location to `core-utils/typechain` - Decoupled Hardhat configuration for ZKSync from EVM. - Updated build process to handle both standard and ZKSync contract artifacts ### Related issues None ### Backward compatibility Yes ### Testing Testing was previously in [feat: zksync support](#4725) PR --------- Co-authored-by: Morteza Shojaei <[email protected]> Co-authored-by: mshojaei-txfusion <[email protected]> Co-authored-by: Le Yu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a series of changes aimed at enhancing zkSync support within the codebase. Key updates include the addition of the zksolc compiler for zkSync, integration of contract artifacts, CLI automation for core deployment, and compatibility adjustments in tests for the zkSync environment. It also includes improvements in contract verification on zkSync explorer and handling gas limits for zkSync deployments.
Drive-by changes
Related issues
No related issue
Backward compatibility
Yes
Testing
Manual testing and some automated tests were performed, including end-to-end tests on zkSync for warp read and apply functionalities.