New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: attempt to fetch operation status in database upon relayer restart #5182

Merged

tkporter merged 27 commits into main from jeff/operation-status

Jan 29, 2025

Collaborator

kamiyaa commented Jan 15, 2025 •

edited

Loading

Description

Add logic to retrieve message status from db before defaulting to PendingOperationStatus::FirstPrepareAttempt.
Add e2e tests to restart relayer and check message statuses were successfully read from db

Drive-by changes

add impl Default to MerkleTreeBuilder to satisfy clippy

Related issues

Fixes bug: Operation status labels are reset across relayer restarts #5060

Backward compatibility

Yes

Testing

Add e2e tests to restart relayer and check message statuses were successfully read from db

kamiyaa added 4 commits

January 15, 2025 15:22


          feat: attempt to fetch operation status in database upon relayer restart

1242b7b


          add run_restart_check

4a9636b


          add e2e check for db message status retrieval

79ae529


          clippy

kamiyaa requested review from tkporter and daniel-savu as code owners

January 15, 2025 13:44

changeset-bot bot commented Jan 15, 2025 •

edited

Loading

⚠️ No Changeset found

Latest commit: d50db51

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR


          revert config

027265e

codecov bot commented Jan 15, 2025 •

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (84f886b) to head (d50db51).
Report is 2 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5182   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21

Components	Coverage Δ
core	`87.80% <ø> (ø)`
hooks	`79.39% <ø> (ø)`
isms	`83.68% <ø> (ø)`
token	`91.27% <ø> (ø)`
middlewares	`79.80% <ø> (ø)`

ameten reviewed

View reviewed changes

rust/main/agents/relayer/src/msg/pending_message.rs Outdated Show resolved Hide resolved

ameten reviewed

View reviewed changes

rust/main/agents/relayer/src/msg/pending_message.rs Outdated Show resolved Hide resolved

daniel-savu reviewed

View reviewed changes

rust/main/agents/relayer/src/msg/pending_message.rs Outdated Show resolved Hide resolved

rust/main/utils/run-locally/src/main.rs Outdated Show resolved Hide resolved

rust/main/utils/run-locally/src/main.rs Outdated Show resolved Hide resolved

kamiyaa added 5 commits

January 20, 2025 23:25


          add debug message when status is not found in db

468ec37


          refactor from_persisted_retries

c4de13d


          update E2E to check for message status invariant

78203a9


          remove spacing

451f78d


          fix spacing

62d60c6

kamiyaa force-pushed the jeff/operation-status branch from e45a249 to 62d60c6 Compare

January 23, 2025 09:28

tkporter reviewed

View reviewed changes

rust/main/agents/relayer/src/msg/pending_message.rs Outdated Show resolved Hide resolved

rust/main/agents/relayer/src/msg/pending_message.rs Outdated Show resolved Hide resolved

rust/main/utils/run-locally/src/main.rs Outdated Show resolved Hide resolved

rust/main/utils/run-locally/src/main.rs Outdated Show resolved Hide resolved

daniel-savu reviewed

View reviewed changes

rust/main/utils/run-locally/src/utils.rs Outdated Show resolved Hide resolved

rust/main/utils/run-locally/src/main.rs Outdated Show resolved Hide resolved

kamiyaa added 2 commits

January 24, 2025 15:35


          refactor get_matching_lines to take in a slice of Vec<String>

98499ab

 - gate debug messages behind "test-utils" feature
 - rename message_retrieval_invariants_met to relayer_restart_invariants_met
 - add comment on message_retry termination invariants


          cargo clippy

709da91

daniel-savu reviewed

View reviewed changes

rust/main/utils/run-locally/src/utils.rs Outdated Show resolved Hide resolved

rust/main/utils/run-locally/src/main.rs Outdated Show resolved Hide resolved

kamiyaa and others added 2 commits

January 24, 2025 21:12


          Update rust/main/utils/run-locally/src/utils.rs

99e651d

Co-authored-by: Daniel Savu <[email protected]>


          refactor: refactor get_matching_lines

87a35ee

daniel-savu reviewed

View reviewed changes

rust/main/utils/run-locally/src/main.rs Outdated Show resolved Hide resolved


          refactor: move wait loop logic into function

858e1a0

kamiyaa mentioned this pull request

feat: run sealevel E2E in parallel with EVM #5280

Draft

daniel-savu mentioned this pull request

[bug] relayer messages are loaded with the wrong operation_status from db #5301

Open


          Merge branch 'main' into jeff/operation-status

b98e781

kamiyaa added 4 commits

January 27, 2025 23:56


          style: cargo clippy

548ea10


          fix: add Default impl to MerkleTreeBuilder to satisfy clippy

57fa387


          Merge branch 'main' into jeff/operation-status

a6159ea


          fix: wait_for_condition returning incorrect value

99fd6f7

kamiyaa force-pushed the jeff/operation-status branch from 05c15ef to 99fd6f7 Compare

January 28, 2025 06:53

tkporter reviewed

View reviewed changes

Collaborator

tkporter left a comment

enjoying the cleanup around run-locally :)

rust/main/agents/relayer/src/msg/pending_message.rs Outdated Show resolved Hide resolved

rust/main/agents/relayer/src/msg/pending_message.rs Outdated Show resolved Hide resolved

rust/main/agents/relayer/src/msg/pending_message.rs Outdated Show resolved Hide resolved

rust/main/agents/relayer/src/msg/pending_message.rs Outdated Show resolved Hide resolved

rust/main/agents/relayer/src/msg/pending_message.rs Show resolved Hide resolved

rust/main/utils/run-locally/src/utils.rs Show resolved Hide resolved

rust/main/utils/run-locally/src/main.rs Show resolved Hide resolved

kamiyaa added 2 commits

January 28, 2025 23:00


          fix: address comments

6d240cb


          style: clippy

041919f

tkporter reviewed

View reviewed changes

rust/main/utils/run-locally/src/main.rs Outdated Show resolved Hide resolved

kamiyaa added 3 commits

January 29, 2025 19:01


          feat: add loop_invariant as a param as well

e03e37b


          fix: add liveliness check to both wait_for_condition calls

1f189d6


          Merge branch 'main' into jeff/operation-status

28808ff

tkporter approved these changes

View reviewed changes

rust/main/utils/run-locally/src/main.rs Show resolved Hide resolved

rust/main/utils/run-locally/src/main.rs Outdated Show resolved Hide resolved

kamiyaa added 2 commits

January 29, 2025 22:10


          fix: rename function

a91b08d


          fix: add shutdown

d50db51

tkporter approved these changes

View reviewed changes

tkporter enabled auto-merge

January 29, 2025 14:36

tkporter added this pull request to the merge queue

Merged via the queue into main with commit f250b19

44 checks passed

tkporter deleted the jeff/operation-status branch

January 29, 2025 16:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet