feat: add coinGeckoId to tokens in warp configs #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to trevor/add-coingecko-id-to-warps
🦋 Changeset detectedLatest commit: 034874e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Seems |
…to trevor/add-coingecko-id-to-warps
Mo-Hussain
approved these changes
Nov 8, 2024
paulbalaji
approved these changes
Nov 8, 2024
github-merge-queue bot
pushed a commit
to hyperlane-xyz/hyperlane-monorepo
that referenced
this pull request
Nov 8, 2024
…ema (#4842) ### Description - Ripped out of #4835, which is necessary so I can merge and release hyperlane-xyz/hyperlane-registry#370 before 4835 ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
github-merge-queue bot
pushed a commit
to hyperlane-xyz/hyperlane-monorepo
that referenced
this pull request
Nov 8, 2024
### Description - Removes the warp monitor specific config format and all the handcrafted yamls from infra - Massive refactor to warp monitor to accommodate this -- tried to make it a bit easier to work work by splitting it into a few files. The changes are generally backward compatible with some small exceptions, like now the metrics use the `TokenStandard` instead of `TokenType` (the former is present in the warp core config, the latter isn't, and there's no way atm to map from the former to the latter) - The warp monitor now takes in a warp ID and gets its config from the registry (recall this is the registry version defined in `.registryrc` if running in the monorepo image) - Deploying the warp monitor now lets you do many at a time and select the ones to deploy interactively. This makes it a bit easier to work with the warp IDs - The names of the warp deploys are based on the warp IDs. Because warp IDs can change as new chains are added, this may cause issues in the future - we'll just need to be cautious of removing the old release to avoid accidentally having 2 of them. For now I think this is fine. The helm release names are also capped at 53 chars so they needed to be truncated - Some changes to the SDK to get the necessary data here. Happy to pull some of these into the warp monitor if people feel they're inappropriate for the SDK (like the `getBridgedSupply`) - Added a test to make sure any warp route IDs in infra are found in the registry - Corresponding PR to the registry here hyperlane-xyz/hyperlane-registry#370 ### Drive-by changes <!-- Are there any minor or drive-by changes also included? --> ### Related issues <!-- - Fixes #[issue number here] --> ### Backward compatibility <!-- Are these changes backward compatible? Are there any infrastructure implications, e.g. changes that would prohibit deploying older commits using this infra tooling? Yes/No --> ### Testing <!-- What kind of testing have these changes undergone? None/Manual/Unit Tests -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a
coinGeckoIdto get an approximate USD value of the token. Some tokens are not yet listed on Coingecko, so an appropriate substitute is chosen.The motivation for this is hyperlane-xyz/hyperlane-monorepo#4835 -- we are removing the special "deployment yaml" that was used by the warp monitor service in favor of WarpCore.
The corresponding zod change is in hyperlane-xyz/hyperlane-monorepo#4835 here https://github.com/hyperlane-xyz/hyperlane-monorepo/pull/4835/files#diff-5d9f643079328fbbe587e59bc31d809c46b98037c045d2df3931b22acf87691fR50 and hasn't yet been released. I'm happy to get that zod change in and do an SDK release first if preferred, though as extra fields are permitted by our types I am cheekliy trying to save myself the hassleThis needs to be merged first hyperlane-xyz/hyperlane-monorepo#4842, then this PR, then hyperlane-xyz/hyperlane-monorepo#4835
Backward compatibility
Backward compatible (our schemas allow extra params, see above, happy to do the sdk release though)
Testing