PREVIEW: IGP interaction refactor #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jmrossy
commented
Dec 30, 2023
| @@ -27,7 +27,6 @@ | |||
| "@typescript-eslint/ban-ts-comment": ["off"], | |||
| "@typescript-eslint/explicit-module-boundary-types": ["off"], | |||
| "@typescript-eslint/no-explicit-any": ["off"], | |||
| "@typescript-eslint/no-floating-promises": ["error"], | |||
There was a problem hiding this comment.
Removed this because the latest formik version makes a bunch of benign form interactions async. They did that to support react ssr/suspense.
jmrossy
commented
Dec 30, 2023
| @@ -31,7 +31,7 @@ | |||
| "bignumber.js": "^9.1.1", | |||
| "buffer": "^6.0.3", | |||
| "cosmjs-types": "^0.9.0", | |||
| "formik": "^2.2.9", | |||
| "formik": "^2.4.5", | |||
There was a problem hiding this comment.
Upgrading to enable async form validation
jmrossy
commented
Dec 30, 2023
| @@ -506,103 +486,6 @@ function ReviewDetails({ visible, tokenRoutes }: { visible: boolean; tokenRoutes | |||
| ); | |||
| } | |||
|
|
|||
| function validateFormValues( | |||
There was a problem hiding this comment.
Moved to it's own file and reorganized (see below)
jmrossy
commented
Dec 30, 2023
jmrossy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE. Using this branch for preview build testing.
Merge #101 instead
Related: hyperlane-xyz/hyperlane-monorepo#3107