-
Notifications
You must be signed in to change notification settings - Fork 286
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: retire connector plugin specific container images, fix docs
BREAKING CHANGE: Container images are being deleted here and will also get deleted from GHCR. Though the public APIs of the Typescript code do not change, still, some parts of the documentation will become invalid until we update it to match the changes here. I invested a large amount of effort into doing this documentation update as part of this change but it is very likely that I've missed a few spots and therefore it is best to mark this as a breaking change in my opinion to call attention to the fact that we still have ways to go with updating the documentation around these container images. 1. Deleted all the container images that were just wrappers around the cmd-api-server container image installing their own npm package from the registry. The reason for this is that they ended up just being maintenance burden since we can achieve the exact same things just by re-using the API server's container image directly. 2. This way we don't have to deal with CVEs in 10x container images when it's really just the one container image that we use as the base that needs to deal with them anyway. 3. I also spent quite a bit of effort in this change to update the README.md files of the packages where previously we had plugin specific container images defined so that the README.md files have the tutorials that are more up to date compared to how they were (most of them had the tutorials completely broken for a long while which was causing a lot of difficulties to the newcomers who were trying to work with the packages). 4. The reason why they got so out of date traces back to the undue maintenance burden of keeping separate images for each connector plugin. We hope that with this simplification we can keep the documentation continuously up to date since it will require less time do so. 5. Also deleted the ci.yaml container building jobs which were relevant to the scope of this change so that we also save on CI resources, another long-running project that's been in need of some attention from the maintainers. Signed-off-by: Peter Somogyvari <[email protected]>
- Loading branch information
Showing
32 changed files
with
429 additions
and
444 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2528,25 +2528,6 @@ jobs: | |
- uses: actions/[email protected] | ||
- name: ghcr.io/hyperledger/cactus-besu-all-in-one | ||
run: DOCKER_BUILDKIT=1 docker build ./tools/docker/besu-all-in-one/ -f ./tools/docker/besu-all-in-one/Dockerfile | ||
ghcr-connector-besu: | ||
needs: | ||
- compute_changed_packages | ||
if: needs.compute_changed_packages.outputs.plugin-ledger-connector-besu-changed == 'true' | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- uses: actions/[email protected] | ||
- name: ghcr.io/hyperledger/cactus-connector-besu | ||
run: DOCKER_BUILDKIT=1 docker build ./packages/cactus-plugin-ledger-connector-besu/ -f ./packages/cactus-plugin-ledger-connector-besu/Dockerfile -t cactus-connector-besu | ||
- if: ${{ env.RUN_TRIVY_SCAN == 'true' }} | ||
name: Run Trivy vulnerability scan for cactus-connector-besu | ||
uses: aquasecurity/[email protected] | ||
with: | ||
image-ref: 'cactus-connector-besu' | ||
format: 'table' | ||
exit-code: '1' | ||
ignore-unfixed: false | ||
vuln-type: 'os,library' | ||
severity: 'CRITICAL,HIGH' | ||
ghcr-connector-corda-server: | ||
runs-on: ubuntu-22.04 | ||
needs: | ||
|
@@ -2567,26 +2548,6 @@ jobs: | |
ignore-unfixed: false | ||
vuln-type: 'os,library' | ||
severity: 'CRITICAL,HIGH' | ||
ghcr-connector-fabric: | ||
runs-on: ubuntu-22.04 | ||
needs: | ||
- compute_changed_packages | ||
if: needs.compute_changed_packages.outputs.plugin-ledger-connector-fabric-changed == 'true' | ||
|
||
steps: | ||
- uses: actions/[email protected] | ||
- name: ghcr.io/hyperledger/cactus-connector-fabric | ||
run: DOCKER_BUILDKIT=1 docker build ./packages/cactus-plugin-ledger-connector-fabric/ -f ./packages/cactus-plugin-ledger-connector-fabric/Dockerfile -t cactus-connector-fabric | ||
- if: ${{ env.RUN_TRIVY_SCAN == 'true' }} | ||
name: Run Trivy vulnerability scan for cactus-connector-fabric | ||
uses: aquasecurity/[email protected] | ||
with: | ||
image-ref: 'cactus-connector-fabric' | ||
format: 'table' | ||
exit-code: '1' | ||
ignore-unfixed: false | ||
vuln-type: 'os,library' | ||
severity: 'CRITICAL,HIGH' | ||
ghcr-corda-all-in-one-flowdb: | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
.cacti-config.json | ||
.config.json | ||
.nyc_output/ | ||
dist/ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -64,7 +64,7 @@ psql "postgres://postgres.DB_NAME:[email protected] | |
|
||
We welcome contributions to Hyperledger Cacti in many forms, and there’s always plenty to do! | ||
|
||
Please review [CONTIRBUTING.md](../../CONTRIBUTING.md) to get started. | ||
Please review [CONTRIBUTING.md](../../CONTRIBUTING.md) to get started. | ||
|
||
## License | ||
|
||
|
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.