Skip to content

Commit

Permalink
test(common): jest migration of the key-converter utility test cases
Browse files Browse the repository at this point in the history
1. Also upgraded the tsx dependency to the latest version.
2. We are planning on retiring ts-node in favor of tsx and this helps with
further triage of it.

Signed-off-by: Peter Somogyvari <[email protected]>
  • Loading branch information
petermetz committed Jul 5, 2024
1 parent 29ec45c commit 315e345
Show file tree
Hide file tree
Showing 9 changed files with 549 additions and 399 deletions.
1 change: 1 addition & 0 deletions .cspell.json
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@
"shrn",
"Smonitor",
"socketio",
"Somogyvari",
"soroban",
"Soroban",
"SPDX",
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -547,7 +547,7 @@ jobs:
FULL_BUILD_DISABLED: true
JEST_TEST_PATTERN: packages/cactus-common/src/test/typescript/(unit|integration|benchmark)/.*/*.test.ts
JEST_TEST_RUNNER_DISABLED: false
TAPE_TEST_PATTERN: '--files={./packages/cactus-common/src/test/typescript/unit/key-converter.test.ts,./packages/cactus-common/src/test/typescript/unit/logging/logger.test.ts}'
TAPE_TEST_PATTERN: './packages/cactus-common/src/test/typescript/unit/logging/logger.test.ts'
TAPE_TEST_RUNNER_DISABLED: false
needs: build-dev
runs-on: ubuntu-22.04
Expand Down
1 change: 0 additions & 1 deletion .taprc
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@ files:
- ./packages/cactus-plugin-ledger-connector-xdai/src/test/typescript/integration/invoke-contract-xdai-json-object.test.ts
- ./packages/cactus-plugin-ledger-connector-xdai/src/test/typescript/integration/openapi/openapi-validation.test.ts
- ./packages/cactus-plugin-ledger-connector-xdai/src/test/typescript/integration/openapi/openapi-validation-no-keychain.test.ts
- ./packages/cactus-common/src/test/typescript/unit/key-converter.test.ts
- ./packages/cactus-common/src/test/typescript/unit/logging/logger.test.ts
- ./packages/cactus-plugin-keychain-aws-sm/src/test/typescript/integration/plugin-keychain-aws-sm.test.ts
- ./packages/cactus-api-client/src/test/typescript/integration/default-consortium-provider.test.ts
Expand Down
1 change: 0 additions & 1 deletion jest.config.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@
"ts-jest": "29.1.1",
"ts-loader": "9.4.4",
"ts-node": "10.9.1",
"tsx": "4.16.2",
"typescript": "5.5.2",
"web3": "4.1.1",
"web3-core": "4.1.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/cactus-cmd-api-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@
"grpc_tools_node_protoc_ts": "5.3.3",
"http-status-codes": "2.1.4",
"protobufjs": "7.2.5",
"tsx": "4.7.0"
"tsx": "4.16.2"
},
"engines": {
"node": ">=18",
Expand Down
Loading

1 comment on commit 315e345

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 0.25.

Benchmark suite Current: 315e345 Previous: 9eefa66 Ratio
cmd-api-server_HTTP_GET_getOpenApiSpecV1 613 ops/sec (±1.62%) 575 ops/sec (±1.69%) 0.94
cmd-api-server_gRPC_GetOpenApiSpecV1 371 ops/sec (±1.55%) 346 ops/sec (±1.37%) 0.93

This comment was automatically generated by workflow using github-action-benchmark.

CC: @petermetz

Please sign in to comment.