-
Notifications
You must be signed in to change notification settings - Fork 285
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
docs(examples/cbdc): fix mismatch of Fabric identities in GET, POST r…
…equests The state keys were not being generated correctly for some reason It was working before without code changes so my best guess is that the Fabric ledger/SDK versions were changed and that's what tripped it up somehow. Fixes #2739 [skip ci] Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: André Augusto <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
- Loading branch information
1 parent
df4fb2f
commit 43980b0
Showing
2 changed files
with
4 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43980b0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
while this fixes the issue, it is generally not a good idea to perform access control based on input from the frontend
43980b0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RafaelAPB That is a very good point. Even though this is "just" documentation (e.g. example code) I'd say we should still make this secure otherwise what we are saying by being this the example is that we recommend doing it this way in production.