feat(cactus-plugin-ledger-connector-fabric-socketio): remove fabric-s…

…ocketio connector

- Remove cactus-plugin-ledger-connector-fabric-socketio connector.
- Refactor discounted cartrade sample to use openapi fabric connector instead of fabric-socketio.
    Sample app will use delegated signing, similar to offline signing in old connector.
- Remove dead code from cmd-socketio-server
- Update fabric SDK to 2.X in all cacti projects, refactor code that use it where necessary.
    Only exception is fabric persistence plugin which uses fabric SDK as dev dependency (for tests).
    It can be updated in separate PR later on.

Depends on: #2644

Signed-off-by: Michal Bajer <[email protected]>

.github/workflows/ci.yaml

@@ -134,11 +134,11 @@ jobs:
         uses: actions/[email protected]
         with:
           script: |
-            const failMsg = "yarn codegen script produced version control " + 
-              "side-effects: source files have been changed by it that are " + 
-              "otherwise are under version control. " + 
-              "This means (99% of the time) that you need to run the " + 
-              "yarn codegen script locally and then include the changes it " + 
+            const failMsg = "yarn codegen script produced version control " +
+              "side-effects: source files have been changed by it that are " +
+              "otherwise are under version control. " +
+              "This means (99% of the time) that you need to run the " +
+              "yarn codegen script locally and then include the changes it " +
               "makes in your own commit when submitting your pull request.";
             core.setFailed(failMsg)
 
@@ -1214,33 +1214,6 @@ jobs:
       - run: npm run configure
       - run: yarn ts-node ./packages/cactus-plugin-ledger-connector-fabric/src/test/typescript/integration/fabric-v2-2-x/run-transaction-with-ws-ids.test.ts
 
-  cactus-plugin-ledger-connector-fabric-socketio:
-    continue-on-error: false
-    env:
-      FULL_BUILD_DISABLED: true
-      JEST_TEST_PATTERN: packages/cactus-plugin-ledger-connector-fabric-socketio/src/test/typescript/(unit|integration|benchmark)/.*/*.test.ts
-      JEST_TEST_RUNNER_DISABLED: false
-      TAPE_TEST_RUNNER_DISABLED: true
-    needs: build-dev
-    runs-on: ubuntu-20.04
-    steps:
-      - name: Use Node.js v16.14.2
-        uses: actions/[email protected]
-        with:
-          node-version: v16.14.2
-      - uses: actions/[email protected]
-
-      - id: yarn-cache
-        name: Restore Yarn Cache
-        uses: actions/[email protected]
-        with:
-          key: ${{ runner.os }}-yarn-${{ hashFiles('./yarn.lock') }}
-          path: ./.yarn/
-          restore-keys: |
-            ${{ runner.os }}-yarn-${{ hashFiles('./yarn.lock') }}
-      - run: yarn --version
-      - run: yarn install
-      - run: ./tools/ci.sh
   cactus-plugin-ledger-connector-go-ethereum-socketio:
     continue-on-error: false
     env:
@@ -1608,13 +1581,13 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-yarn-${{ hashFiles('./yarn.lock') }}
       - run: ./tools/ci.sh
-      
+
       - name: Install Foundry
         uses: foundry-rs/foundry-toolchain@v1
 
       - name: Run solidity tests
         run: cd packages/cactus-plugin-htlc-eth-besu && forge test -vvvvv
-              
+
   cactus-test-plugin-htlc-eth-besu-erc20:
     continue-on-error: false
     env:

examples/cactus-example-discounted-asset-trade/README.md

@@ -26,10 +26,10 @@ Alice will use credentials and other Indy formats such as schema and definition
 
 ## Setup Overview
 
-### fabric-socketio-validator
+### fabric-socketio
 
 - Validator for fabric ledger.
-- Docker networks: `fabric-all-in-one_testnet-2x`, `cactus-example-discounted-asset-trade-net`
+- Started as part of discounted asset trade BLP.
 
 ### ethereum-validator
 
@@ -114,8 +114,6 @@ Alice will use credentials and other Indy formats such as schema and definition
    ```
    cactus-example-discounted-asset-trade-ethereum-validator | listening on *:5050
    ...
-   cactus-example-discounted-asset-trade-fabric-socketio-validator | listening on *:5040
-   ...
    cactus-example-discounted-asset-trade-indy-validator | 2022-01-31 16:00:49,552 INFO success: validator entered RUNNING state, process has stayed up for > than 1 seconds (startsecs)
    ...
    cactus-example-discounted-asset-trade-indy-validator-nginx | 2022/01/31 16:00:49 [notice] 1#1: start worker process 35
@@ -154,9 +152,6 @@ For development purposes, it might be useful to run the sample application outsi
 1. Configure cactus and start the ledgers as described above.
 1. Run `./script-dockerless-config-patch.sh` from `cactus-example-discounted-asset-trade/` directory. This will patch the configs and copy it to global location.
 1. Start validators (each in separate cmd window).
-   1. ```bash
-      cd packages/cactus-plugin-ledger-connector-fabric-socketio/ && npm run start
-      ```
    1. ```bash
       cd packages/cactus-plugin-ledger-connector-go-ethereum-socketio/ && npm run start
       ```
@@ -229,7 +224,7 @@ For development purposes, it might be useful to run the sample application outsi
    **After sending the requests**
 
    - The transactions are executed by order.
-   - When the following log appears on the BLP console, the transactions are completed.
+   - When the following log appears on the BLP console, the transactions are completed (you may need to scroll a bit to find it).
 
    ```
    [INFO] BusinessLogicAssetTrade - ##INFO: completed asset-trade, businessLogicID: guks32pf, tradeID: *******-001
@@ -295,3 +290,8 @@ For development purposes, it might be useful to run the sample application outsi
    ./script-cleanup.sh
    popd
    ```
+
+#### Possible improvements
+- Ethereum events are duplicated, causing trade to proceed even if previous step was not successfull.
+   - Handle this case properly - ignore duplciated events, move forward only if current step was completed.
+   - Investigate and fix duplicated events in Verifier / Ethereum connector (or use openapi ethereum connector).