Skip to content

Commit

Permalink
build(rust-compiler): retire the container image and the test cases
Browse files Browse the repository at this point in the history
1. This started off with me trying to fix the CVEs in the rust-compiler image.
2. I was able to get rid of most of them by changing the base image to ubuntu-24.04
3. The remaining high and critical ones were due to wasm-pack so went to see
if we could upgrade that but we are already on the latest which is 8 months old.
The vulnerabilities were reported on the wasm-pack repo 6 months ago along with
a pull request that fixes them, neither the issue nor the pull request fixing it
received any attention from the wasm-pack maintainers which lead me to believe
that it is a liability to depend on it right now and we should instead look into
a different tooling where the maintenance happens to have a little more resources
dedicated to it. Java/Kotlin might be the way to go.
4. I've also looked into possible alternatives to wasm-pack but the only
other tool I found that does the same thing is cargo-web which hasn't had
a new release for 4 years and counting and has even more CVEs plaguing it
than wasm-pack.
5. The official web assembly site links to wasm-pack when it comes to
compiling to it from Rust so there's probably not a better maintained tool
out there, but if someone finds something I'd love to start using it.
In the meantime I'll just archive/retire/delete the rust compiler image
and the tests associated with it because it's a maintenance burden that
we don't need to carry.

Signed-off-by: Peter Somogyvari <[email protected]>
  • Loading branch information
petermetz committed Mar 12, 2024
1 parent 8ff98b3 commit f3974d2
Show file tree
Hide file tree
Showing 9 changed files with 0 additions and 612 deletions.
15 changes: 0 additions & 15 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2358,21 +2358,6 @@ jobs:
ignore-unfixed: true
vuln-type: 'os,library'
severity: 'CRITICAL,HIGH'
ghcr-rust-compiler:
runs-on: ubuntu-20.04
steps:
- uses: actions/[email protected]
- name: ghcr.io/hyperledger/cactus-rust-compiler
run: DOCKER_BUILDKIT=1 docker build ./tools/docker/rust-compiler/ -f ./tools/docker/rust-compiler/Dockerfile -t cactus-rust-compiler
- name: Run Trivy vulnerability scan for cactus-rust-compiler
uses: aquasecurity/[email protected]
with:
image-ref: 'cactus-rust-compiler'
format: 'table'
exit-code: '1'
ignore-unfixed: true
vuln-type: 'os,library'
severity: 'CRITICAL,HIGH'
ghcr-test-npm-registry:
runs-on: ubuntu-20.04
steps:
Expand Down
60 changes: 0 additions & 60 deletions .github/workflows/rust-compiler-publish.yaml

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -166,12 +166,6 @@ export {
SampleCordappEnum,
} from "./corda/sample-cordapp-enum";

export {
IRustcContainerOptions,
K_DEFAULT_RUSTC_CONTAINER_CMD,
RustcContainer,
} from "./rustc-container/rustc-container";

export {
ISawtoothTestLedgerOptions,
SAWTOOTH_LEDGER_DEFAULT_OPTIONS,
Expand All @@ -183,8 +177,6 @@ export {
SubstrateTestLedger,
} from "./substrate-test-ledger/substrate-test-ledger";

export { RustcBuildCmd } from "./rustc-container/rustc-build-cmd";

export { Streams } from "./common/streams";

export { isRunningInGithubAction } from "./github-actions/is-running-in-github-action";
Expand Down

This file was deleted.

This file was deleted.

Loading

0 comments on commit f3974d2

Please sign in to comment.