Skip to content

Commit

Permalink
test(test-tooling): fix FabricTestLedger INVALID_ENDORSER_TRANSACTION
Browse files Browse the repository at this point in the history 
* reverts changes of commit 3371772,
which seems to be breaking the Fabric Test Ledger

Results of further investigation into the root cause done by Peter:
1. The URLs we specify have the `grpcs://` protocol specified meaning that
TLS is used for securing the connection.
2. Certificates that are generated by the Fabric-provided boostrap scripts
when setting up crypto materials for the ledger are generated with `localhost`
as the hostname instead of the IP address of localhost.
3. The C++ gRPC implementation does not support mixing IP addresses and
hostnames when it comes to connections that are using TLS, e.g. if the
certificate we are using was made out for `localhost` then it won't work
for `127.0.0.1` even though technically from our perspective they meaning
the same thing (do note however that technically localhost could be set
up to resolve to something other than 127.0.0.1 in a DNS server so the
difference is meaningful).

Source: grpc/grpc#2691

closes #3009

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: André Augusto <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
  • Loading branch information
@AndreAugusto11 @outSH
AndreAugusto11 authored and outSH committed Feb 28, 2024
1 parent 6a476a0 commit f57ab70
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions packages/cactus-test-tooling/src/main/typescript/fabric/fabric-test-ledger-v1.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -389,20 +389,20 @@ export class FabricTestLedgerV1 implements ITestLedger {
// peer0.org1.example.com
const privatePort = 7051;
const hostPort = await Containers.getPublicPort(privatePort, cInfo);
ccp.peers["peer0.org1.example.com"].url = `grpcs://127.0.0.1:${hostPort}`;
ccp.peers["peer0.org1.example.com"].url = `grpcs://localhost:${hostPort}`;
}
if (ccp.peers["peer1.org1.example.com"]) {
// peer1.org1.example.com
const privatePort = 8051;
const hostPort = await Containers.getPublicPort(privatePort, cInfo);
ccp.peers["peer1.org1.example.com"].url = `grpcs://127.0.0.1:${hostPort}`;
ccp.peers["peer1.org1.example.com"].url = `grpcs://localhost:${hostPort}`;
}
{
// ca_peerOrg1
const privatePort = 7054;
const hostPort = await Containers.getPublicPort(privatePort, cInfo);
const { certificateAuthorities: cas } = ccp;
cas["ca.org1.example.com"].url = `https://127.0.0.1:${hostPort}`;
cas["ca.org1.example.com"].url = `https://localhost:${hostPort}`;
}

// FIXME - this still doesn't work. At this moment the only successful tests
Expand All @@ -417,7 +417,7 @@ export class FabricTestLedgerV1 implements ITestLedger {

const privatePort = 7050;
const hostPort = await Containers.getPublicPort(privatePort, cInfo);
const url = `grpcs://127.0.0.1:${hostPort}`;
const url = `grpcs://localhost:${hostPort}`;
const ORDERER_PEM_PATH_FABRIC_V1 =
"/fabric-samples/first-network/crypto-config/ordererOrganizations/example.com/tlsca/tlsca.example.com-cert.pem";
const ORDERER_PEM_PATH_FABRIC_V2 =
Expand Down Expand Up @@ -462,11 +462,11 @@ export class FabricTestLedgerV1 implements ITestLedger {
// with discovery
// {
// const { grpcOptions } = ccp.peers["peer0.org1.example.com"];
// grpcOptions.hostnameOverride = `127.0.0.1`;
// grpcOptions.hostnameOverride = `localhost`;
// }
// {
// const { grpcOptions } = ccp.peers["peer1.org1.example.com"];
// grpcOptions.hostnameOverride = `127.0.0.1`;
// grpcOptions.hostnameOverride = `localhost`;
// }
}
return ccp;
Expand Down Expand Up @@ -516,7 +516,7 @@ export class FabricTestLedgerV1 implements ITestLedger {
const privatePortPeer0 = parseFloat(urlGrpcs.replace(/^\D+/g, ""));

const hostPort = await Containers.getPublicPort(privatePortPeer0, cInfo);
ccp["peers"][peer0Name]["url"] = `grpcs://127.0.0.1:${hostPort}`;
ccp["peers"][peer0Name]["url"] = `grpcs://localhost:${hostPort}`;

// if there is a peer1
if (ccp.peers["peer1.org" + orgName + ".example.com"]) {
Expand All @@ -527,7 +527,7 @@ export class FabricTestLedgerV1 implements ITestLedger {
privatePortPeer1,
cInfo,
);
ccp["peers"][peer1Name]["url"] = `grpcs://127.0.0.1:${hostPortPeer1}`;
ccp["peers"][peer1Name]["url"] = `grpcs://localhost:${hostPortPeer1}`;
}
{
// ca_peerOrg1
Expand All @@ -537,7 +537,7 @@ export class FabricTestLedgerV1 implements ITestLedger {

const caHostPort = await Containers.getPublicPort(caPort, cInfo);
const { certificateAuthorities: cas } = ccp;
cas[caName].url = `https://127.0.0.1:${caHostPort}`;
cas[caName].url = `https://localhost:${caHostPort}`;
}

// FIXME - this still doesn't work. At this moment the only successful tests
Expand All @@ -552,7 +552,7 @@ export class FabricTestLedgerV1 implements ITestLedger {

const privatePort = 7050;
const hostPort = await Containers.getPublicPort(privatePort, cInfo);
const url = `grpcs://127.0.0.1:${hostPort}`;
const url = `grpcs://localhost:${hostPort}`;
const ORDERER_PEM_PATH_FABRIC_V1 =
"/fabric-samples/first-network/crypto-config/ordererOrganizations/example.com/tlsca/tlsca.example.com-cert.pem";
const ORDERER_PEM_PATH_FABRIC_V2 =
Expand Down Expand Up @@ -597,11 +597,11 @@ export class FabricTestLedgerV1 implements ITestLedger {
// with discovery
// {
// const { grpcOptions } = ccp.peers["peer0.org1.example.com"];
// grpcOptions.hostnameOverride = `127.0.0.1`;
// grpcOptions.hostnameOverride = `localhost`;
// }
// {
// const { grpcOptions } = ccp.peers["peer1.org1.example.com"];
// grpcOptions.hostnameOverride = `127.0.0.1`;
// grpcOptions.hostnameOverride = `localhost`;
// }
}
return ccp;
Expand Down Expand Up @@ -1277,7 +1277,7 @@ export class FabricTestLedgerV1 implements ITestLedger {
const containerInfo = await this.getContainerInfo();
const port = await Containers.getPublicPort(22, containerInfo);
const sshConfig: SshConfig = {
host: "127.0.0.1",
host: "localhost",
privateKey,
username: "root",
port,
Expand Down

1 comment on commit f57ab70

@github-actions
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 0.05.

Benchmark suite Current: f57ab70 Previous: 6a476a0 Ratio
cmd-api-server_HTTP_GET_getOpenApiSpecV1 641 ops/sec (±1.74%) 649 ops/sec (±1.66%) 1.01
cmd-api-server_gRPC_GetOpenApiSpecV1 396 ops/sec (±1.66%) 415 ops/sec (±2.27%) 1.05

This comment was automatically generated by workflow using github-action-benchmark.

CC: @petermetz

Please sign in to comment.