Skip to content

Commit

Permalink
build(tools/docker/indy-sdk-cli): fix deprecation deb.nodesource.com/…
Browse files Browse the repository at this point in the history
…setup_16.x

**Primary Change:**

In the Dockerfile, the issue related to NodeJS was addressed by
updating the NodeJS installation method to use the new NodeSource
installation method. The previous method using
`curl -sL https://deb.nodesource.com/setup_16.x | bash -`
had become deprecated, so the new method was applied for compatibility
with the latest practices.

The specific changes made in the Dockerfile are as follows:

1. Removed the old installation method for NodeJS:

   ```Dockerfile
   # Removed the deprecated NodeJS installation method
   # RUN curl -sL https://deb.nodesource.com/setup_16.x | bash -
   ```

2. Added the new NodeSource installation method:

```Dockerfile
RUN curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | \
        gpg --dearmor -o /usr/share/keyrings/nodesource-archive-keyring.gpg \
    && echo "deb [arch=amd64 signed-by=/usr/share/keyrings/nodesource-archive-keyring.gpg] \
    https://deb.nodesource.com/node bionic main" | \
    tee /etc/apt/sources.list.d/nodesource.list
```

[skip ci]

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: urvish667 <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
  • Loading branch information
urvish667 authored and petermetz committed Oct 13, 2023
1 parent a04fc5b commit f5ede41
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions tools/docker/indy-sdk-cli/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,9 @@ RUN apt-get update \
make \
&& rm -rf /var/lib/apt/lists/*

# NodeJS
RUN curl -sL https://deb.nodesource.com/setup_16.x | bash -
# NodeJS - Updated to use the new NodeSource installation method
RUN curl -fsSL https://deb.nodesource.com/gpgkey/nodesource-repo.gpg.key | gpg --dearmor -o /usr/share/keyrings/nodesource-archive-keyring.gpg \
&& echo "deb [arch=amd64 signed-by=/usr/share/keyrings/nodesource-archive-keyring.gpg] https://deb.nodesource.com/node bionic main" | tee /etc/apt/sources.list.d/nodesource.list

# Indy-sdk
RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys CE7709D068DB5E88 \
Expand Down

0 comments on commit f5ede41

Please sign in to comment.