feat(weaver-corda): support array of remote views, consequent user fl… #2638
Conversation
sandeepnRES
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan and
VRamakrishna
as code owners
|
LGTM (not approving it as Peter has already approved it) |
There was a problem hiding this comment.
@sandeepnRES Please fix the DCO and pass it back for review! Let me know if you need any help with the git mechanics of course!
Done. |
There was a problem hiding this comment.
@sandeepnRES Please fix the DCO and pass it back for review! Let me know if you need any help with the git mechanics of course!
Done.
@sandeepnRES Thank you! Now there's a few more checks that seem to be broken like the unit_test_interop_cordapp job. Could you take a look at those?
.../src/main/kotlin/org/hyperledger/cacti/weaver/imodule/corda/flows/WriteExternalStateFlows.kt
Outdated
Show resolved
Hide resolved
...rda/corda-simple-application/workflows-kotlin/src/main/kotlin/com/example/flow/SimpleFlow.kt
Outdated
Show resolved
Hide resolved
...rda/corda-simple-application/workflows-kotlin/src/main/kotlin/com/example/flow/SimpleFlow.kt
Outdated
Show resolved
Hide resolved
...rda/corda-simple-application/workflows-kotlin/src/main/kotlin/com/example/flow/SimpleFlow.kt
Outdated
Show resolved
Hide resolved
...pplication/clients/src/main/kotlin/com/cordaSimpleApplication/client/AssetTransferManager.kt
Show resolved
Hide resolved
sandeepnRES
force-pushed
the
main
branch
3 times, most recently
from
c2c3c0a to
a7a69c6
Compare
There was a problem hiding this comment.
@sandeepnRES These required jobs are still failing (could be more but these are the first ones that popped up on my radar)
asset-exchange-corda-localasset-transfer-localdata-sharing-docker-local
Yeah working on it. |
sandeepnRES
force-pushed
the
main
branch
5 times, most recently
from
db93041 to
198648d
Compare
…ow call Signed-off-by: Sandeep Nishad <[email protected]>
Signed-off-by: Sandeep Nishad <[email protected]>
…ow call
Closes #2470