build(corda-all-in-one-obligation): fix build unable to select packages #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
jagpreetsinghsasan
approved these changes
Sep 7, 2023
VRamakrishna
approved these changes
Sep 7, 2023
|
LGTM |
1. Fixed the OpenSSH related problems by wiping the default installation of it that ships with the distro (Alpine Linux images) 2. Updated the kotlin samples repository's code manually so that it specifies the platform version as 11 instead of 12 for the basic contracts which is what we need for Corda v4.8 and v4.9 as well (I'm guessing that platform version 12 will stand for v5 when it becomes GA but not sure) The manual update is done via sed-ing at image build time right after the kotlin samples repository has been cloned. Fixes hyperledger-cacti#2621 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
petermetz/issue2621
branch
from
e90d9a3 to
445ae05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of it that ships with the distro (Alpine Linux images)
specifies the platform version as 11 instead of 12 for the basic contracts
which is what we need for Corda v4.8 and v4.9 as well (I'm guessing that
platform version 12 will stand for v5 when it becomes GA but not sure)
The manual update is done via sed-ing at image build time right after
the kotlin samples repository has been cloned.
Fixes #2621
Signed-off-by: Peter Somogyvari [email protected]