build(weaver-go): Update code and dependencies in Go packages for Fabric #2660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VRamakrishna
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan and
sandeepnRES
as code owners
petermetz
reviewed
Sep 7, 2023
There was a problem hiding this comment.
@VRamakrishna Please fix the commit lint check [1]. On top of that, some of my recommendations:
- I'd also recommend specifying the component/scope as something else than
updatein the commit messages - I would also consider using
buildas the type of the commits instead offixbecause users will see these in the release notes and not be able to assign any meaning to it because it's not something that was broken in the previous release and now fixed but instead it's just that the build was broken for a period of time during development in-between releases (to which the users would most likely just be noise rather than signal).
Sorry for the nit-picking, these are just recommendations, not an actual change request because I also consider these highly subjective.
[1]
sandeepnRES
reviewed
Sep 8, 2023
sandeepnRES
reviewed
Sep 8, 2023
VRamakrishna
changed the title
|
@petermetz @sandeepnRES Fixed commits and code as per your suggestions. Please review again. @sandeepnRES It'll need your approval as Jagpreet has added his. |
sandeepnRES
reviewed
Sep 11, 2023
sandeepnRES
approved these changes
Sep 12, 2023
Updated Fabric Go SDK library based on common protobuf changes. Updated dependency and instructions in Weaver Go CLI for Fabric. Updated go.mod files in components of the Weaver Fabric-interop-cc. Signed-off-by: VRamakrishna <[email protected]>
Updated local build versions for Weaver Fabric driver and Weaver IIN Agent. Updated Weaver relay dependencies. Signed-off-by: VRamakrishna <[email protected]>
…codes Signed-off-by: VRamakrishna <[email protected]>
…ion change Minor refactoring in Fabric testnet launch script. Reverting unnecessary version downgrade in Weaver relay Cargo dependencies. Signed-off-by: VRamakrishna <[email protected]>
Signed-off-by: VRamakrishna <[email protected]>
|
@petermetz |
@VRamakrishna Yeah, I traced it back to the new npm publish of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
weaver/sdks/fabric/go-sdkto work with the latest protos and release a new version of the library.go.modfor Fabric Interop Chaincode, Fabric Go CLI, and sample chaincodes.Cargo.lock.