Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(setup): remove install-yarn and document new yarn setup #2704

Merged
merged 1 commit into from
Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/.dast-nuclei-cmd-api-server.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:

- run: nuclei --version

- run: yarn configure
- run: npm run configure

- name: Create URLs file for Nuclei
run: |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
with:
node-version: v16.9.1

- run: yarn configure
- run: npm run configure

- name: build-cactus-plugin-ledger-connector-corda-kotlin-client
run: |
Expand Down
2 changes: 1 addition & 1 deletion BUILD.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ The `npm run watch` script in action:
nvm use 16.14.2
```
* Yarn
* `npm run install-yarn` (from within the project directory)
* `npm run enable-corepack` (from within the project directory)
* [Docker Engine](https://docs.docker.com/engine/install/ubuntu/). Make sure that Docker is working and running, for example, running ``docker ps -aq``
* Docker Compose
* OpenJDK (Corda support Java 8 JDK but do not currently support Java 9 or higher)
Expand Down
12 changes: 6 additions & 6 deletions examples/supply-chain-app/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,16 +54,16 @@ DOCKER_BUILDKIT=1 docker build \

On the terminal, issue the following commands:

1. `npm run install-yarn`
2. `yarn configure`
1. `npm run enable-corepack`
2. `npm run configure`
3. `yarn start:example-supply-chain`

## Debugging the Example Application Locally

On the terminal, issue the following commands (steps 1 to 6) and then perform the rest of the steps manually.

1. `npm run install-yarn`
2. `yarn configure`
1. `npm run enable-corepack`
2. `npm run configure`
3. `yarn build:dev`
4. `cd ./examples/supply-chain-app/`
5. `yarn --no-lockfile`
Expand All @@ -77,8 +77,8 @@ On the terminal, issue the following commands (steps 1 to 6) and then perform th

## Live Reloading the GUI Application

1. `npm run install-yarn`
2. `yarn configure`
1. `npm run enable-corepack`
2. `npm run configure`
3. `yarn build:dev`
4. Locate the `.vscode/template.launch.json` file
5. Within that file locate the entry named `"Example: Supply Chain App"`
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
"reset:yarn-lock": "yarn run init-registries && yarn install --update-checksums --force",
"reset": "run-s reset:git reset:node-modules reset:yarn-lock configure",
"configure": "npm run init-registries && yarn install && yarn build:dev:backend",
"install-yarn": "npm install --global [email protected]",
"set-yarn-version": "yarn set version stable",
"enable-corepack": "npm i -g corepack && corepack enable && corepack prepare [email protected] --activate",
"custom-checks": "TS_NODE_PROJECT=./tools/tsconfig.json node --trace-deprecation --experimental-modules --abort-on-uncaught-exception --loader ts-node/esm --experimental-specifier-resolution=node ./tools/custom-checks/run-custom-checks.ts",
Expand Down