fix(security): vulnerabilities found in cactus-rust-compiler #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zondervancalvez
force-pushed
the
zondervancalvez/issue2042
branch
10 times, most recently
from
bc0b919 to
11540e2
Compare
zondervancalvez
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
zondervancalvez
force-pushed
the
zondervancalvez/issue2042
branch
from
11540e2 to
4442a90
Compare
petermetz
requested changes
Sep 28, 2023
There was a problem hiding this comment.
- The config file is in the project root. Does this mean that if the same vulnerability appears in production code, it will also be ignored there? If yes, then I'll ask to localize the configuration file to the rust-compiler image only, so that the scenario above cannot happen.
- Please remove the "fixes ####" declaration so that the related issue is not auto-closed.
- Instead of "fixes ..." just document the relation and that this is a temporary fix and that we need to do the actual fix later (the issue can be set to low priority this way)
This fix will ignore AsymmetricPrivateKey (private-key) Fixes hyperledger-cacti#2042 Signed-off-by: zondervancalvez <[email protected]>
zondervancalvez
force-pushed
the
zondervancalvez/issue2042
branch
from
4442a90 to
ae4f9e2
Compare
|
@zondervancalvez any updates on this? |
|
Not working on this as its not production grade image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix will ignore AsymmetricPrivateKey (private-key)
Fixes #2042