docs: add Pull Request Template #2784
Conversation
ruzell22
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
ruzell22
force-pushed
the
prtemplate91
branch
2 times, most recently
from
4c49b81 to
e7bd8e2
Compare
There was a problem hiding this comment.
The code isnt rendered correctly: https://github.com/ruzell22/cactus/blob/prtemplate91/PULL_REQUEST_TEMPLATE.md (No new lines)
You can install Markdown All in One extension in vscode and then press Ctrl + Shift + V to check the rendered output
ruzell22
force-pushed
the
prtemplate91
branch
2 times, most recently
from
bc9ae99 to
2c2aad1
Compare
|
Hello @jagpreetsinghsasan @petermetz , pushed a changed and the md file is now displaying the checkboxes as expected. |
There was a problem hiding this comment.
@ruzell22 LGTM - but please add a [skip ci] declaration to the commit message so that we are not burning money on the CI for docs (the check that cancels the CI run if it's docs only is still not working so we have to try and pay some attention to this manually unfortunately.
ruzell22
force-pushed
the
prtemplate91
branch
from
2c2aad1 to
2eb6a4f
Compare
|
@petermetz noted on that Peter, thank you. I have updated the commit message with |
Checkbox is updated so it will reflect as expected. fixes: hyperledger-cacti#91 related to: hyperledger-cacti#2708 Signed-off-by: ruzell22 <[email protected]> [skip ci]
petermetz
force-pushed
the
prtemplate91
branch
from
2eb6a4f to
fe429f1
Compare
Checkbox is updated so it will reflect as expected.
fixes: #91
related to: #2708
Signed-off-by: ruzell22 [email protected]