Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cactus-example-discounted-asset-trade): use openapi sawtooth connector #2827

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Oct 23, 2023

  • Refactor discounted asset trade sample to use openapi sawtooth connector
    instead of sawtooth-socketio.
  • Remove sawtooth-socketio connector since it's not used any more.

Depends on: https://github.com/hyperledger/cacti/pull/2825

Signed-off-by: Michal Bajer [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…nector

- Refactor discounted asset trade sample to use openapi sawtooth connector
    instead of sawtooth-socketio.
- Remove sawtooth-socketio connector since it's not used any more.

Depends on: hyperledger-cacti#2825

Signed-off-by: Michal Bajer <[email protected]>
@petermetz petermetz force-pushed the remove_sawtooth_socketio_connector_pr branch from 2b1b541 to 0617217 Compare November 3, 2023 00:00
@petermetz petermetz enabled auto-merge (rebase) November 3, 2023 00:00
@petermetz petermetz merged commit 86d6b38 into hyperledger-cacti:main Nov 3, 2023
36 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants