Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector-besu): toBuffer only supports 0x-prefixed hex #2831

Merged
merged 1 commit into from
Dec 10, 2023

Conversation

ruzell22
Copy link
Contributor

@ruzell22 ruzell22 commented Oct 25, 2023

Commit to be reviewed

fix(connector-besu): toBuffer only supports 0x-prefixed hex

Primary Changes
---------------
1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from
3000000 to its hex equivalent

fixes: #2791

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@ruzell22
Copy link
Contributor Author

ruzell22 commented Oct 25, 2023

24 tests successfully ran and passed on $ yarn ts-node ./packages/cactus-plugin-ledger-connector-besu/src/test/typescript/integration/plugin-ledger-connector-besu/deploy-contract/private-deploy-contract-from-json-web3-eea.test.ts after changing the 3000000 to its hex equivalent

image

@ruzell22 ruzell22 changed the title fix(connector-besu): toBuffer only supports 0x-prefixed hex was given… fix(connector-besu): toBuffer only supports 0x-prefixed hex Oct 25, 2023
@ruzell22 ruzell22 force-pushed the besuhex2791 branch 3 times, most recently from f9b0938 to 9f5730c Compare October 26, 2023 01:21
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruzell22 The test case fails on my machine when I'm testing it (the ESM Module resolution problem)
Did you forget to push your changes by any chance?

@ruzell22 ruzell22 force-pushed the besuhex2791 branch 5 times, most recently from c40bbf4 to 9afe701 Compare November 7, 2023 03:16
@ruzell22
Copy link
Contributor Author

ruzell22 commented Nov 7, 2023

Hello @petermetz , I have tried with a fresh clone of the repository and retested (successful) and repushed the changes as well. Let me know if it works on your end as well, thank you.

@petermetz
Copy link
Contributor

Hello @petermetz , I have tried with a fresh clone of the repository and retested (successful) and repushed the changes as well. Let me know if it works on your end as well, thank you.

@ruzell22 Next time please re-request the review so that it pop ups on my list of "waiting for your review" pull requests.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ruzell22 LGTM

Primary Changes
---------------
1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from
3000000 to its hex equivalent

fixes: hyperledger-cacti#2791

Signed-off-by: ruzell22 <[email protected]>
@petermetz petermetz merged commit 1d00e32 into hyperledger-cacti:main Dec 10, 2023
99 of 134 checks passed
@petermetz petermetz deleted the besuhex2791 branch December 10, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(connector-besu): toBuffer only supports 0x-prefixed hex was given: 3000000
3 participants