-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(connector-besu): toBuffer only supports 0x-prefixed hex #2831
Conversation
f9b0938
to
9f5730c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruzell22 The test case fails on my machine when I'm testing it (the ESM Module resolution problem)
Did you forget to push your changes by any chance?
c40bbf4
to
9afe701
Compare
Hello @petermetz , I have tried with a fresh clone of the repository and retested (successful) and repushed the changes as well. Let me know if it works on your end as well, thank you. |
@ruzell22 Next time please re-request the review so that it pop ups on my list of "waiting for your review" pull requests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ruzell22 LGTM
Primary Changes --------------- 1. Updated private-deploy-contract-from-json-web3-eea.test.ts gaslimit from 3000000 to its hex equivalent fixes: hyperledger-cacti#2791 Signed-off-by: ruzell22 <[email protected]>
9afe701
to
d0ec97d
Compare
Commit to be reviewed
fix(connector-besu): toBuffer only supports 0x-prefixed hex
fixes: #2791
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.