feat(indy-sdk): replace indy SDK with AFJ #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
outSH
commented
Nov 3, 2023
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Dec 11, 2023
- Add `IndyTestLedger` class to setup test indy ledger for testing purposes. - Add functional tests for new test ledger class. - Minor fix in cleaning up sample indy test ledger. Depends on hyperledger-cacti#2861 Signed-off-by: Michal Bajer <[email protected]>
5 tasks
outSH
force-pushed
the
remove_indy_sdk_pr
branch
from
f0a3357 to
c36bfe7
Compare
|
This PR/issue depends on:
|
outSH
force-pushed
the
remove_indy_sdk_pr
branch
from
c36bfe7 to
aa71d71
Compare
outSH
force-pushed
the
remove_indy_sdk_pr
branch
from
aa71d71 to
1b8a11c
Compare
outSH
force-pushed
the
remove_indy_sdk_pr
branch
3 times, most recently
from
1b8a11c to
5010f4d
Compare
- Refactor test ledger `indy-testnet` into `indy-all-in-one`. New package uses
the latest indy version, has healtcheck script, updated startup / cleanup
scripts.
- Remove `indy-sdk-cli` image since it's not used anymore.
- Refactor `cactus-example-discounted-asset-trade` to use own aries agent
instead of indy connector. This way it doesn't need to use indy-sdk anymore,
and python indy connector can be safely removed / upgraded.
- Update sample app readme to explain current workflow.
- Remove client scripts since `cactus-example-discounted-asset-trade-client`
can now be used to interact with the sample app.
- Add `cactus-example-discounted-asset-trade-client`. It contains script for
setting up test credentials on the ledger, script with interactive menu for
interacting with `cactus-example-discounted-asset-trade` sample app,
and bunch of helper functions used for writing these apps.
Depends on hyperledger-cacti#2859
Depends on hyperledger-cacti#2860
Signed-off-by: Michal Bajer <[email protected]>
outSH
force-pushed
the
remove_indy_sdk_pr
branch
from
5010f4d to
503c8a7
Compare
petermetz
added a commit
to outSH/cactus
that referenced
this pull request
Jan 21, 2024
- Add `IndyTestLedger` class to setup test indy ledger for testing purposes. - Add functional tests for new test ledger class. - Minor fix in cleaning up sample indy test ledger. Peter's changes: 1. Rebased onto upstream/main as of 2024-01-21 which was a bit of a challenge on account of this being quite old (110 commits behind) 2. Meaning that there's a chance that I messed up some of the conflict resolutions in a way that is sub-optimal, please forgive if this is the case! Depends on hyperledger-cacti#2861 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Michal Bajer <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
that referenced
this pull request
Jan 21, 2024
- Add `IndyTestLedger` class to setup test indy ledger for testing purposes. - Add functional tests for new test ledger class. - Minor fix in cleaning up sample indy test ledger. Peter's changes: 1. Rebased onto upstream/main as of 2024-01-21 which was a bit of a challenge on account of this being quite old (110 commits behind) 2. Meaning that there's a chance that I messed up some of the conflict resolutions in a way that is sub-optimal, please forgive if this is the case! Depends on #2861 Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: Michal Bajer <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
indy-testnetintoindy-all-in-one. New package usesthe latest indy version, has healtcheck script, updated startup / cleanup
scripts.
indy-sdk-cliimage since it's not used anymore.cactus-example-discounted-asset-tradeto use own aries agentinstead of indy connector. This way it doesn't need to use indy-sdk anymore,
and python indy connector can be safely removed / upgraded.
cactus-example-discounted-asset-trade-clientcan now be used to interact with the sample app.
cactus-example-discounted-asset-trade-client. It contains script forsetting up test credentials on the ledger, script with interactive menu for
interacting with
cactus-example-discounted-asset-tradesample app,and bunch of helper functions used for writing these apps.
Depends on #2859
Depends on #2860
Signed-off-by: Michal Bajer [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.