fix(connector-besu): error handling of DeployContractSolidityBytecodeEndpoint #2869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
changed the title
takeutak
approved these changes
Nov 13, 2023
jagpreetsinghsasan
approved these changes
Nov 14, 2023
|
This PR/issue depends on: |
…Endpoint 1. Uses the new utility function from the core package in the catch block so that HTTP `statusCode` is matching the intent of the thrower (e.g. correctly differentiates between user-error and developer error) 2. Updates the `deployContract` method of the besu connector so that it correctly specifies the intent of the errors thrown as either user error or developer error via setting the `statusCode` property of the HTTP errors to either 4xx or 5xx depending on the cause. 3. Provides a template for future similar changes (of which we'll need dozens to update all the REST API endpoints) Depends on hyperledger-cacti#2868 Related to but does not conclude: hyperledger-cacti#1747 Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
fix-rest-endpoint-error-handling-pattern-besu-deploy-contract-solidity-bytecode-endpoint
branch
from
5816904 to
4efc773
Compare
petermetz
deleted the
fix-rest-endpoint-error-handling-pattern-besu-deploy-contract-solidity-bytecode-endpoint
branch
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so that HTTP statusCode is matching the intent of the thrower (e.g.
correctly differentiates between user-error and developer error)
correctly specifies the intent of the errors thrown as either user error
or developer error via setting the statusCode property of the HTTP errors
to either 4xx or 5xx depending on the cause.
dozens to update all the REST API endpoints)
Depends on #2868
Related to but does not conclude: #1747
Signed-off-by: Peter Somogyvari [email protected]