test(geth-test-ledger): add basic tests #2906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
reviewed
Dec 1, 2023
petermetz
reviewed
Dec 1, 2023
petermetz
approved these changes
Dec 1, 2023
|
This PR/issue depends on:
|
outSH
force-pushed
the
add_test_geth_ledger_tests_pr
branch
from
ccca00f to
ab080ef
Compare
outSH
force-pushed
the
add_test_geth_ledger_tests_pr
branch
2 times, most recently
from
d04fb6b to
5742f67
Compare
- Add test suite for geth-test-ledger package. - Add new test suit to CI - It was initially proposed in hyperledger-cacti#2588, I've added some cleanups and improvements. - Run codegen, update missing deps, sort package.json, fix type in socketio-test-setup-helpers, to fix some CI. Closes: hyperledger-cacti#2579 Co-authored-by: Tomasz Awramski <[email protected]> Signed-off-by: Michal Bajer <[email protected]>
outSH
force-pushed
the
add_test_geth_ledger_tests_pr
branch
from
5742f67 to
3827001
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2579
Depends on #2879
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.