Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cactus_validator_socketio_indy): remove old python connector #2949

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

outSH
Copy link
Contributor

@outSH outSH commented Dec 12, 2023

  • Remove old python connector cactus_validator_socketio_indy. It's been
    replaced with socketio-based cactus-plugin-ledger-connector-aries.

Depends on #2947

Signed-off-by: Michal Bajer [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@outSH Thank you very much! LGTM

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

This PR/issue depends on:

- Remove old python connector cactus_validator_socketio_indy. It's been
    replaced with socketio-based cactus-plugin-ledger-connector-aries.
Depends on hyperledger-cacti#2947

Signed-off-by: Michal Bajer <[email protected]>
@outSH outSH force-pushed the remove_indy_python_connector_pr branch from 30a1ace to 46443d0 Compare January 29, 2024 14:56
@outSH outSH enabled auto-merge (rebase) January 29, 2024 14:57
@outSH outSH merged commit 73ff593 into hyperledger-cacti:main Jan 29, 2024
130 of 147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants