fix(weaver-fabric-node-sdk): made AES key length configurable in ECIES functions #2953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VRamakrishna
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
sandeepnRES and
outSH
as code owners
1 task
sandeepnRES
previously approved these changes
Dec 18, 2023
outSH
approved these changes
Dec 18, 2023
sandeepnRES
dismissed
their stale review
Need some changes to be done to fix failing tests and others.
sandeepnRES
approved these changes
Dec 21, 2023
…S functions The Weaver Fabric interoperation-node-sdk used the "aes-128-ctr" algorithm in a hardcoded manner for asymmetric encryption/decryption. 128-bit AES, though secure for classical computing, is quantum-unsafe. So an option is added to use "aes-256-ctr" on demand. The "aes-128-ctr" algorithm is still supported because many signing keys, typically those used in the Fabric testnets, have embedded elliptic curve parameters with key length 16 bytes, and those still need to be supported. Signed-off-by: VRamakrishna <[email protected]>
…ting identity mgmt Partially reverting changes made in https://github.com/hyperledger/cacti/pull/2901. These changes made the IIN Agent chaincode operations fail. Also fixed typos and formatting in the docs. Signed-off-by: VRamakrishna <[email protected]>
…tnet Signed-off-by: VRamakrishna <[email protected]>
Modified the SDK functions to be compatible with the Weaver Fabric Interoperation Chaincode. Signed-off-by: VRamakrishna <[email protected]>
This was referenced Jan 24, 2024
VRamakrishna
referenced
this pull request
Jan 24, 2024
…al compilation Also reverted a documentation change as per code change in https://github.com/hyperledger/cacti/pull/2953. Signed-off-by: VRamakrishna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Weaver Fabric interoperation-node-sdk used the "aes-128-ctr" algorithm in a hardcoded manner for asymmetric encryption/decryption. 128-bit AES, though secure for classical computing, is quantum-unsafe.
So an option is added to use "aes-256-ctr" on demand.
The "aes-128-ctr" algorithm is still supported because many signing keys, typically those used in the Fabric testnets, have embedded elliptic curve parameters with key length 16 bytes, and those still need to be supported.
Fixes https://github.com/hyperledger/cacti/issues/2765 and supersedes https://github.com/hyperledger/cacti/pull/2907.
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.