-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(fabric-driver): added weaver fabric driver as cacti package #2963
feat(fabric-driver): added weaver fabric driver as cacti package #2963
Conversation
@sandeepnRES Can you edit the opening comment and add some description (in bullet points) about what this feature is and how it is part of the Cacti integration roadmap? |
Added package LGTM. Please add some descriptions as per my comments before merging though. |
4e343e1
to
7ad535f
Compare
7ad535f
to
dfe7a34
Compare
@sandeepnRES Big +1 on that. However trivial/straightforward it seems to us, it is always good to explain for future contributors/maintainers what the change is in a little more detail with some historical context, etc. |
dfe7a34
to
8def2c7
Compare
@sandeepnRES CI is failing, could you investigate? I think the package name is duplicated in both places and that's causing the scripts to fail |
@sandeepnRES Do you need any help investigating this one? |
8def2c7
to
958109e
Compare
Hi @petermetz Sorry for the delay, this PR slipped our of my mind. What do you think will be better, to rename this package? Or to remove the one inside |
@sandeepnRES My vote goes for The longer we keep pull requests open the more conflicts they get with |
8e30685
to
a774cc5
Compare
Hi @petermetz @VRamakrishna @outSH |
@sandeepnRES OK, works for me. Please run yarn install to update the lock file. > configure
> npm run init-registries && yarn install && yarn build:dev:backend
> init-registries
> npm config set @iroha2:registry=https://nexus.iroha.tech/repository/npm-group/
➤ YN0000: Yarn detected that the current workflow is executed from a public pull request. For safety the hardened mode has been enabled.
➤ YN0000: It will prevent malicious lockfile manipulations, in exchange for a slower install time. You can opt-out if necessary; check our documentation for more details.
➤ YN0000: · Yarn 4.1.0
➤ YN0000: ┌ Resolution step
Resolution step
➤ YN0000: └ Completed in 23s 737ms
➤ YN0000: ┌ Post-resolution validation
Post-resolution validation
➤ YN0028: +"@hyperledger/cacti-plugin-weaver-driver-fabric@workspace:packages/cacti-plugin-weaver-driver-fabric":
➤ YN0028: + version: 0.0.0-use.local
➤ YN0028: + resolution: "@hyperledger/cacti-plugin-weaver-driver-fabric@workspace:packages/cacti-plugin-weaver-driver-fabric"
➤ YN0028: + languageName: unknown
➤ YN0028: + linkType: soft
➤ YN0028: +
➤ YN0028: The lockfile would have been modified by this install, which is explicitly forbidden.
➤ YN0000: └ Completed in 0s 243ms
➤ YN0000: · Failed with errors in 24s 2ms
Error: Process completed with exit code 1. |
c379d2d
to
244fbb7
Compare
6f9768c
to
dabdcda
Compare
fix(fabric-driver): yarn lint errors Signed-off-by: Sandeep Nishad <[email protected]>
dabdcda
to
c1e1e71
Compare
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit