Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector-fabric): address CVEs: CVE-2022-21190, CVE-2021-3918 #2967

Merged

Conversation

adrianbatuto
Copy link
Contributor

@adrianbatuto adrianbatuto commented Jan 3, 2024

Updated the version of the api server used in the docker file.

Fixes #2864

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@jagpreetsinghsasan
Copy link
Contributor

jagpreetsinghsasan commented Jan 4, 2024

@adrianbatuto please fix the commit and PR lint failing, rest LGTM

@jagpreetsinghsasan jagpreetsinghsasan changed the title tools(connector-fabric): address CVEs: CVE-2022-21190, CVE-2021-3918 fix(connector-fabric): address CVEs: CVE-2022-21190, CVE-2021-3918 Jan 11, 2024
@jagpreetsinghsasan
Copy link
Contributor

jagpreetsinghsasan commented Jan 15, 2024

@adrianbatuto the Commit Lint is still failing, can you please check on that?

@jagpreetsinghsasan
Copy link
Contributor

You can refer to this PR for reference: https://github.com/hyperledger/cacti/pull/2818

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adrianbatuto ^^ +1 to what @jagpreetsinghsasan commented

@adrianbatuto adrianbatuto force-pushed the adrianbatuto/issue2864 branch 2 times, most recently from a5d2748 to 43a4433 Compare January 23, 2024 05:22
@petermetz petermetz force-pushed the adrianbatuto/issue2864 branch from 43a4433 to e6662f5 Compare January 25, 2024 21:07
@petermetz petermetz self-requested a review January 25, 2024 21:07
@petermetz
Copy link
Contributor

@adrianbatuto Next time please re-request review otherwise it won't pop up in my review queue.

1 similar comment
@petermetz
Copy link
Contributor

@adrianbatuto Next time please re-request review otherwise it won't pop up in my review queue.

@petermetz petermetz enabled auto-merge (rebase) January 25, 2024 21:08
@petermetz petermetz merged commit 11e775d into hyperledger-cacti:main Jan 25, 2024
124 of 146 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tools(connector-fabric): address CVEs: CVE-2022-21190, CVE-2021-3918
4 participants