Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Satp final #2968

Closed
Closed

Conversation

outsidethecode
Copy link
Contributor

@outsidethecode outsidethecode commented Jan 4, 2024

Note: This PR is a replacement for https://github.com/hyperledger/cacti/pull/2748. A new PR is needed because it's very hard to merge the old PR, work on which started several months ago and has accumulated a lot of conflicts with the main branch.

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

outsidethecode and others added 30 commits June 29, 2023 15:24
outsidethecode and others added 29 commits October 3, 2023 08:01
Initial documentation on how to run the satp gateway and test it
…on-receipt

SATP steps 1.1, 1.2, 2.1A, 2.2, 2.3, and 2.4
corrected the version of cacti_weaver_protos_rs and added the copyright statement

removed the code copied from fabric-cli
corrected the version of cacti_weaver_protos_rs and added the copyright statement

removed the code copied from fabric-cli
Merge the SATP implementation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants