build(typescript): upgrade compiler to v5.x project-wide #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna and
sandeepnRES
as code owners
petermetz
force-pushed
the
ts5_upgrade_pr
branch
from
4ec81c1 to
fca3ec9
Compare
|
This PR/issue depends on:
|
- Upgrade typescript to 5.3.3 - Fix minor compilation issues where problems occurred. - Upgraded the protoc-gen-ts package to 0.8.7 which supports typescript 5.x whereas the previously used version only supported typescript 4.9 or earlier. This was causing the yarn codegen script to fail (the code generator script) Update from Peter: Bumped up protoc-gen-ts to latest versionl. Closes hyperledger-cacti#2700 Depends on hyperledger-cacti#2971 Signed-off-by: Michal Bajer <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
ts5_upgrade_pr
branch
from
fca3ec9 to
86ac37c
Compare
|
@outSH FYI:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2700
Depends on #2971
Signed-off-by: Michal Bajer [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.