-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: rename OpenAPI extension x-hyperledger-cactus #3010
refactor: rename OpenAPI extension x-hyperledger-cactus #3010
Conversation
@aldousalvarez please fix the PR and the commit message to the standard one I have mentioned several times. |
d555936
to
b63c154
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aldousalvarez #2689 is about renaming them in the .json files. This PR is renaming it in the .yaml one which is generated from the .json one.
Once you rename it in the .json files the .yaml file should update automatically.
Primary Changes ---------------- 1. Updated openapi.yaml in connector-corda to match the project rename x-hyperledger-cacti Fixes hyperledger-cacti#2689 Signed-off-by: aldousalvarez <[email protected]>
b63c154
to
f14a056
Compare
@petermetz the .json file is already updated with the correct one which is x-hyperledger-cacti, when I tried to clean and configure it does not update automatically so I just updated the .yaml manually |
In that case #2689 was already completed, no need for this PR.
Let's uncover the reason why it's not getting updated. Could you please investigate why is that? |
@petermetz okay will dol investigate on this one and will let you know as soon as possible if I have found what is causing this issue and how to fix this as well |
Hello @petermetz should I create a new PR or will you reopen this PR and its Issue because I have changes in cactus-plugin-ledger-connector-polkadot that needs to rename the openapi extension to x-hyperledger-cacti And also regarding the removal of the openapi.yaml in cactus-plugin-ledger-connector-corda should I create also a separate PR and issue or should I just include it here and just explain why we are removing it |
@aldousalvarez You could re-open this one just please make sure to explain the context to it, e.g. the details of the conversation you and I had on Wednesday.
Separate issue + separate PR please. Detailed explanation of all the conversations we had and what was uncovered in your investigation, etc. |
Commit to be reviewed
refactor: rename OpenAPI extension x-hyperledger-cactus
Fixes #2689
Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.