chore: make spellcheck script less noisy with --no-progress flag #3033
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quality of life improvement for contributors.
Prior to this the cspell tool that we invoke for spellchecking had listed every single file as a separate log line on standard output during it's execution and the files that had issues were marked in that list, but since we have more than a thousand files, it was a lot of scrolling and scanning to find the files that had spelling mistakes in them during development time.
With the
--no-progress
flag now passed in to cspell it will only print the files that were found to have spelling mistakes in them which makes contributor productivity a little better.Pull Request Requirements
upstream/main
branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-s
flag when usinggit commit
command. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.