Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cbdc-example): removed dependency on chai and update tests #3035

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

AndreAugusto11
Copy link
Contributor

  • Chai was removed as dependency of the cbdc-backend package
  • A test scenario was removed in the 'bridge-back' feature due to having duplicated logic with another one in the same file
  • Some tests were failing due to timeouts, so we added an explicit and generous timeout limit for each step

closes #3034

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreAugusto11 fix means that something was fixed that would've been broken in production but this only touches the tests and the test dependencies.

The idea behind the above: People reading the release notes would get this on the list of bugs that were fixed but wouldn't really know what to make of it because it has no effect on their production deployments.

And therefore my request is to set the scope to test instead of fix

Looks good otherwise!

@AndreAugusto11 AndreAugusto11 changed the title fix(cbdc-example): removed dependency on chai and update tests test(cbdc-example): removed dependency on chai and update tests Feb 28, 2024
@AndreAugusto11
Copy link
Contributor Author

@petermetz thanks a lot. I'm always in a struggle with the naming, but getting better!! 😀

@petermetz
Copy link
Contributor

@petermetz thanks a lot. I'm always in a struggle with the naming, but getting better!! 😀

@AndreAugusto11 No worries! It takes a long time (speaking from personal experience) to build up the muscle memory for these kind of things so until then the best course of action is to just keep working on it!

@petermetz petermetz enabled auto-merge (rebase) February 28, 2024 20:25
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@outSH outSH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AndreAugusto11 Thanks, looks great, please update the yarn.lock file to fix the tests and we're good to go :)

You could also pin the dependency versions in cactus-example-cbdc-bridging-backend/package.json (e.g. "cucumber": "^5.0.3", -> "5.0.3"). This should be done in separate PR but since the change is so small I think it's OK to fix it "by the way" - completely optional :)

auto-merge was automatically disabled February 29, 2024 16:10

Head branch was pushed to by a user without write access

* Chai was removed as dependency of the cbdc-backend package
* A test scenario was removed in the 'bridge-back' feature due to
having duplicated logic with another one in the same file
* Some tests were failing due to timeouts, so we added an explicit
and generous timeout limit for each step

closes hyperledger-cacti#3034

Signed-off-by: André Augusto <[email protected]>
@AndreAugusto11
Copy link
Contributor Author

@outSH thanks, also pinned all versions accordingly.

@AndreAugusto11 AndreAugusto11 requested a review from outSH February 29, 2024 20:05
@outSH outSH merged commit 4ca792d into hyperledger-cacti:main Mar 1, 2024
130 of 147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(cbdc-example): the tests of the CBDC app are not running
3 participants