Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(build): change NodeJS version in BUILD.md to v18.18.2 #3036

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

rwat17
Copy link
Contributor

@rwat17 rwat17 commented Feb 29, 2024

  • fix node version in BUILD.md what caused type error in corepack
    and prevented yarn from installing packages correctly.
    Error message when using node 16: Type Error: URL.canParse is not a function

Signed-off-by: Tomasz Awramski [email protected]

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwat17 Thank you very much! LGTM!

@petermetz petermetz enabled auto-merge (rebase) March 1, 2024 03:15
@outSH outSH force-pushed the update-build-md branch from 35a6e63 to 0ec02f4 Compare March 1, 2024 13:43
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwat17 One sec though, I'll do some refactoring on the commit message / PR title

@petermetz petermetz self-requested a review March 1, 2024 17:01
@petermetz petermetz changed the title fix(build): change node version in BUILD.md docs(build): change NodeJS version in BUILD.md to v18.18.2 Mar 2, 2024
- Update the NodeJS version in BUILD.md what caused type error in corepack
and prevented yarn from installing packages correctly.
Error message when using node 16: Type Error: URL.canParse is not a function

Co-authored-by: Peter Somogyvari <[email protected]>

Signed-off-by: Tomasz Awramski <[email protected]>
Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz merged commit 5a0ebb4 into hyperledger-cacti:main Mar 2, 2024
130 of 147 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants