style(docs/examples/cbdc): applied auto-formatting to CBDC example code #3052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petermetz
requested review from
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Mar 3, 2024
Also upgraded the ESLint related packages such as the typescript parser plugin and all the other plugins or configuration management packages related to ESLint in general. The reason why it's important that we keep up to date with ESLint is because newer versions of Typescript are not getting backported to older versions of ESLint fast enough (if at all) so to be able to reliably lint our newer Typescript code, we need to keep up to date with ESLint as well. In addition to the dependency upgrades we are also applying the automatic formatter's changes that it started making after the upgrade. To-do for later: Consolidate the ESLint versions used among the different components of the project because right now we still have a few packages that declare much older versions of ESLint such as 3.x and 4.x. Depends on hyperledger-cacti#3052 because that pull request also applies some of the automatic formatting changes that were forgotten in an earlier pull request. Signed-off-by: Peter Somogyvari <[email protected]>
5 tasks
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Mar 4, 2024
Also upgraded the ESLint related packages such as the typescript parser plugin and all the other plugins or configuration management packages related to ESLint in general. The reason why it's important that we keep up to date with ESLint is because newer versions of Typescript are not getting backported to older versions of ESLint fast enough (if at all) so to be able to reliably lint our newer Typescript code, we need to keep up to date with ESLint as well. In addition to the dependency upgrades we are also applying the automatic formatter's changes that it started making after the upgrade. To-do for later: Consolidate the ESLint versions used among the different components of the project because right now we still have a few packages that declare much older versions of ESLint such as 3.x and 4.x. Depends on hyperledger-cacti#3052 because that pull request also applies some of the automatic formatting changes that were forgotten in an earlier pull request. Signed-off-by: Peter Somogyvari <[email protected]>
Just ran `yarn lint` on `main` and it applied these formatting changes so I'm applying the changes to make sure others don't have to deal with the auto-formatter littering their commits with automated changes like these. The bigger story here is that this somehow passed the CI which makes me suspect that we forgot to add a check to the lint action that would verify that post-lint there are no files changed compared to the git revision that is being linted, so figuring this out is a to-do still and should go into it's own pull request later on. Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
style-example-docs-cbdc-linter-auto-format
branch
from
acf5456 to
2964c78
Compare
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Mar 4, 2024
Also upgraded the ESLint related packages such as the typescript parser plugin and all the other plugins or configuration management packages related to ESLint in general. The reason why it's important that we keep up to date with ESLint is because newer versions of Typescript are not getting backported to older versions of ESLint fast enough (if at all) so to be able to reliably lint our newer Typescript code, we need to keep up to date with ESLint as well. In addition to the dependency upgrades we are also applying the automatic formatter's changes that it started making after the upgrade. To-do for later: Consolidate the ESLint versions used among the different components of the project because right now we still have a few packages that declare much older versions of ESLint such as 3.x and 4.x. Depends on hyperledger-cacti#3052 because that pull request also applies some of the automatic formatting changes that were forgotten in an earlier pull request. Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
that referenced
this pull request
Mar 4, 2024
Also upgraded the ESLint related packages such as the typescript parser plugin and all the other plugins or configuration management packages related to ESLint in general. The reason why it's important that we keep up to date with ESLint is because newer versions of Typescript are not getting backported to older versions of ESLint fast enough (if at all) so to be able to reliably lint our newer Typescript code, we need to keep up to date with ESLint as well. In addition to the dependency upgrades we are also applying the automatic formatter's changes that it started making after the upgrade. To-do for later: Consolidate the ESLint versions used among the different components of the project because right now we still have a few packages that declare much older versions of ESLint such as 3.x and 4.x. Depends on #3052 because that pull request also applies some of the automatic formatting changes that were forgotten in an earlier pull request. Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
added a commit
to petermetz/cacti
that referenced
this pull request
Mar 10, 2024
Also upgraded the ESLint related packages such as the typescript parser plugin and all the other plugins or configuration management packages related to ESLint in general. The reason why it's important that we keep up to date with ESLint is because newer versions of Typescript are not getting backported to older versions of ESLint fast enough (if at all) so to be able to reliably lint our newer Typescript code, we need to keep up to date with ESLint as well. In addition to the dependency upgrades we are also applying the automatic formatter's changes that it started making after the upgrade. To-do for later: Consolidate the ESLint versions used among the different components of the project because right now we still have a few packages that declare much older versions of ESLint such as 3.x and 4.x. Depends on hyperledger-cacti#3052 because that pull request also applies some of the automatic formatting changes that were forgotten in an earlier pull request. Signed-off-by: Peter Somogyvari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just ran
yarn lintonmainand it applied these formatting changesso I'm applying the changes to make sure others don't have to deal with
the auto-formatter littering their commits with automated changes like
these.
The bigger story here is that this somehow passed the CI which makes me
suspect that we forgot to add a check to the lint action that would
verify that post-lint there are no files changed compared to the git
revision that is being linted, so figuring this out is a to-do still and
should go into it's own pull request later on.
Signed-off-by: Peter Somogyvari [email protected]
Pull Request Requirements
upstream/mainbranch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.-sflag when usinggit commitcommand. You may refer to this link for more information.Character Limit
A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.