Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade and pin to ubuntu-22.04 project-wide for CI runner images #3066

Conversation

petermetz
Copy link
Contributor

  1. This does not upgrade all the container images that we build and publish
    as part of the project, it just upgrades the runner images that are being
    used by the continuous integration environment.
  2. I also deleted a .yaml file that I left in the diff of another pull request
    by accident. Apologies for the littering.
  3. Upgrade: as-in, I bumped the 20.04 versions to 22.04
  4. Pin: as-in, replaced ubuntu-latest with ubuntu-22.04 everywhere.
  5. Reasoning: 24.04 is out now and so we have to keep up with the times
    because soon there'll be a stop to security patches even on what used to
    be LTS (20.04). It is better to find out now if we have a problem with
    ubuntu 22.04 rather than later when it's become urgent to upgrade.
  6. The risk of something breaking because of these upgrades is most likely
    low since ubuntu is one of the most stable distributions out there.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz petermetz force-pushed the ci-upgrade-and-pin-to-ubuntu-2204-project-wide branch from d6ab600 to 49d57c1 Compare March 12, 2024 14:58
1. This does not upgrade all the container images that we build and publish
as part of the project, it just upgrades the runner images that are being
used by the continuous integration environment.
2. I also deleted a .yaml file that I left in the diff of another pull request
by accident. Apologies for the littering.
3. Upgrade: as-in, I bumped the 20.04 versions to 22.04
4. Pin: as-in, replaced `ubuntu-latest` with `ubuntu-22.04` everywhere.
5. Reasoning: 24.04 is out now and so we have to keep up with the times
because soon there'll be a stop to security patches even on what used to
be LTS (20.04). It is better to find out now if we have a problem with
ubuntu 22.04 rather than later when it's become urgent to upgrade.
6. The risk of something breaking because of these upgrades is most likely
low since ubuntu is one of the most stable distributions out there.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the ci-upgrade-and-pin-to-ubuntu-2204-project-wide branch from 49d57c1 to d34e104 Compare March 13, 2024 17:18
@petermetz petermetz merged commit fd8fc6f into hyperledger-cacti:main Mar 13, 2024
131 of 144 checks passed
@petermetz petermetz deleted the ci-upgrade-and-pin-to-ubuntu-2204-project-wide branch March 13, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants