Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix scripts - use run-time-error instead of run-time-error-cjs #3070

Conversation

petermetz
Copy link
Contributor

  1. The -cjs version of the package was put into place because in the
    production packages we needed it to be able to import the dependency
    despite us not using ESM just yet.
  2. We did a blanket search and replace at the time which seemed like a
    good idea but turns out it wasn't because there are some tooling scripts
    (the ones in this diff) that are already using ESM and for those the
    -cjs flavored package started breaking the code.
  3. So this change is just a partial/selective/surgical revert of the
    earlier project-wide migratin from run-time-error to run-time-error-cjs.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. The `-cjs` version of the package was put into place because in the
production packages we needed it to be able to import the dependency
despite us not using ESM just yet.
2. We did a blanket search and replace at the time which seemed like a
good idea but turns out it wasn't because there are some tooling scripts
(the ones in this diff) that are already using ESM and for those the
-cjs flavored package started breaking the code.
3. So this change is just a partial/selective/surgical revert of the
earlier project-wide migratin from run-time-error to run-time-error-cjs.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the tools-fix-bump-openapi-spec-dep-version-script-runtime-error-cjs-import-crash branch from 1a62670 to d477f6a Compare March 12, 2024 07:32
@petermetz petermetz merged commit 1d11d6c into hyperledger-cacti:main Mar 12, 2024
128 of 146 checks passed
@petermetz petermetz deleted the tools-fix-bump-openapi-spec-dep-version-script-runtime-error-cjs-import-crash branch March 12, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants