Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: retire npm-test-registry and whitepaper builder images #3074

Conversation

petermetz
Copy link
Contributor

  1. They have vulnerabilities that are non-trivial effort to fix.
  2. We haven't used them in a while so it makes sense for them to retire.
  3. We can put them back in action whenever they become needed again,
    they'll always be available in the git commit log.
  4. This saves on CI resources which is something we are short on and
    constantly need to optimize further.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. They have vulnerabilities that are non-trivial effort to fix.
2. We haven't used them in a while so it makes sense for them to retire.
3. We can put them back in action whenever they become needed again,
they'll always be available in the git commit log.
4. This saves on CI resources which is something we are short on and
constantly need to optimize further.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-retire-images-test-registry-whitepaper branch from 5a9bb48 to b977329 Compare March 12, 2024 08:04
@petermetz petermetz merged commit 9667f4e into hyperledger-cacti:main Mar 12, 2024
131 of 144 checks passed
@petermetz petermetz deleted the test-retire-images-test-registry-whitepaper branch March 12, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants