Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(github): stop using NodeJS v16 based actions due to deprecation #3080

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

petermetz
Copy link
Contributor

No changes other than the mass find & replacing of the GitHub actions
that we use for setting up NodeJS, checking code out and caching.

Address the warnings that started popping up in the CI that look like
this, asking for a mass-upgrade of CI action versions:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20:
actions/[email protected],
actions/[email protected],
actions/[email protected]
For more information see:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Fixes #3079

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

No changes other than the mass find & replacing of the GitHub actions
that we use for setting up NodeJS, checking code out and caching.

Address the warnings that started popping up in the CI that look like
this, asking for a mass-upgrade of CI action versions:

> Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20:
> actions/[email protected],
> actions/[email protected],
> actions/[email protected]
> For more information see:
> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Fixes hyperledger-cacti#3079

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the petermetz/issue3079 branch from 6126e6d to c203bc9 Compare March 13, 2024 04:50
Copy link
Contributor

@VRamakrishna VRamakrishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petermetz petermetz merged commit dec0f3b into hyperledger-cacti:main Mar 13, 2024
131 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci(github): stop using NodeJS v16 based actions due to deprecation
3 participants