Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(connector-fabric): move integration tests to use Fabric v2.5.6 AIO #3082

Conversation

petermetz
Copy link
Contributor

  1. This fixes many flakes that we were suffering from before with the
    older versions of the AIO image.
  2. There could still be other flakes lurking around, but their numbers
    should definitely be going down with this change due to the increased
    stability of the new AIO image.

Signed-off-by: Peter Somogyvari [email protected]

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@petermetz petermetz enabled auto-merge (rebase) March 12, 2024 18:57
@petermetz petermetz force-pushed the test-connector-fabric-migrate-integration-tests-to-fabric-v256-aio-image branch from a2e5da7 to 2869791 Compare March 12, 2024 21:20
Copy link
Contributor

@jagpreetsinghsasan jagpreetsinghsasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VRamakrishna
Copy link
Contributor

@petermetz The Weaver test network scripts use Fabric v2.5.0: https://github.com/hyperledger/cacti/blob/main/weaver/tests/network-setups/fabric/dev/Makefile. Do you want this to be upgraded to 2.5.6 too?

@petermetz
Copy link
Contributor Author

@petermetz The Weaver test network scripts use Fabric v2.5.0: https://github.com/hyperledger/cacti/blob/main/weaver/tests/network-setups/fabric/dev/Makefile. Do you want this to be upgraded to 2.5.6 too?

@VRamakrishna
If the image itself is stable and the tests are not flaking because of it then I would prioritize it low and put it in the backlog (the task of upgrading it to v2.5.6 or newer).
If the image suffers from instability like our old v.2.2.x images were, then it's higher priority and I'd recommend upgrading ASAP as well.

Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1. This fixes many flakes that we were suffering from before with the
older versions of the AIO image.
2. There could still be other flakes lurking around, but their numbers
should definitely be going down with this change due to the increased
stability of the new AIO image.

Signed-off-by: Peter Somogyvari <[email protected]>
@petermetz petermetz force-pushed the test-connector-fabric-migrate-integration-tests-to-fabric-v256-aio-image branch from 2869791 to b512248 Compare March 15, 2024 14:14
@petermetz petermetz merged commit df6661e into hyperledger-cacti:main Mar 15, 2024
130 of 144 checks passed
@petermetz petermetz deleted the test-connector-fabric-migrate-integration-tests-to-fabric-v256-aio-image branch March 15, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants