Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(gui): gui structure change to make adding more ledgers easier #3083

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

rwat17
Copy link
Contributor

@rwat17 rwat17 commented Mar 13, 2024

  • change folder structure
  • each ledger-plugin now has separate folder and configuration
  • added status page for available plugins

Signed-off-by: Tomasz Awramski [email protected]

Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwat17 LGTM with a small nit, please see above!

tools/docker/supabase-all-in-one/src/run-supabase.sh Outdated Show resolved Hide resolved
@rwat17 rwat17 force-pushed the gui-new-structure branch from cf218ef to b11486e Compare March 14, 2024 09:49
@rwat17 rwat17 requested a review from petermetz March 14, 2024 09:51
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwat17 rwat17 force-pushed the gui-new-structure branch from b11486e to 28bc118 Compare March 18, 2024 09:37
Copy link
Contributor

@izuru0 izuru0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rwat17 rwat17 force-pushed the gui-new-structure branch 3 times, most recently from 89d502e to f1fa5e0 Compare March 19, 2024 09:39
Copy link
Contributor

@petermetz petermetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwat17 Still LGTM but the build is failing :/

- change folder structure
- each ledger-plugin now has separate folder and configuration
- added status page for available plugins

Signed-off-by: Tomasz Awramski <[email protected]>
@rwat17 rwat17 force-pushed the gui-new-structure branch from 7889903 to d328381 Compare March 20, 2024 12:15
@rwat17 rwat17 requested a review from petermetz March 20, 2024 12:35
@rwat17
Copy link
Contributor Author

rwat17 commented Mar 20, 2024

@rwat17 Still LGTM but the build is failing :/

I think it is fixed now :)

@petermetz petermetz merged commit e42cac7 into hyperledger-cacti:main Mar 20, 2024
131 of 144 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants