-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(gui): gui structure change to make adding more ledgers easier #3083
Conversation
a945783
to
cf218ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwat17 LGTM with a small nit, please see above!
cf218ef
to
b11486e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/cacti-ledger-browser-react/src/main/typescript/components/AppShell/Home.tsx
Outdated
Show resolved
Hide resolved
b11486e
to
28bc118
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
89d502e
to
f1fa5e0
Compare
f1fa5e0
to
7889903
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwat17 Still LGTM but the build is failing :/
- change folder structure - each ledger-plugin now has separate folder and configuration - added status page for available plugins Signed-off-by: Tomasz Awramski <[email protected]>
7889903
to
d328381
Compare
I think it is fixed now :) |
Signed-off-by: Tomasz Awramski [email protected]