build(go.mod): project-wide bump google.golang.org/protobuf to v1.33.0 #3087
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
dependabot
bot
requested review from
petermetz,
takeutak,
izuru0,
jagpreetsinghsasan,
VRamakrishna,
sandeepnRES and
outSH
as code owners
|
There are CI tests failing in some dependabot's PRs, I'll investigate and fix this, please don't merge these before that. |
@sandeepnRES OK, no worries! I'll close all the other ones and keep this one open with the contents of all of them combined (e.g. a mass upgrade of the package in question to v1.33.0. |
There was a problem hiding this comment.
Holding this off until we investigate with @sandeepnRES what's going wrong exactly.
So not really a change request just blocking the merge for now as discussed in the comments.
petermetz
changed the title
|
The logs for future reference (of the failing jobs) |
|
@sandeepnRES First thing I noticed is that the tests complain about the lock file not being updated (the sum file) so I'll do a bunch of |
1. Bumps google.golang.org/protobuf from 1.30.0 to 1.33.0 throughout the project. 2. Also ran `go mod tidy` in all 14 sub-directories where we have the go.mod files in question located. --- updated-dependencies: - dependency-name: google.golang.org/protobuf Co-authored-by: Peter Somogyvari <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Peter Somogyvari <[email protected]>
petermetz
force-pushed
the
dependabot/go_modules/weaver/core/network/fabric-interop-cc/interfaces/asset-mgmt/google.golang.org/protobuf-1.33.0
branch
from
2280652 to
39ea37d
Compare
|
@sandepnRES The |
|
Hi @petermetz Sorry I didn't realise about this PR, I fixed other PRs by dependabot which did the same upgrades. One is merged PR #3249, and other two are pending to be merged #3263 and PR #3275 |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
bot
deleted the
dependabot/go_modules/weaver/core/network/fabric-interop-cc/interfaces/asset-mgmt/google.golang.org/protobuf-1.33.0
branch
@sandeepnRES Please try to let me know earlier next time so I don't waste my time. |
Bumps google.golang.org/protobuf from 1.30.0 to 1.33.0.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.